Make DOMWindowProperty::m_frame private

third_party/WebKit/Source/core/frame/History.cpp

 /*
  * Copyright (C) 2007 Apple Inc.  All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
  *    notice, this list of conditions and the following disclaimer in the
@@ skipping 50 matching lines @@
 {
 }
 
 DEFINE_TRACE(History)
 {
     DOMWindowProperty::trace(visitor);
 }
 
 unsigned History::length() const
 {
-    if (!m_frame || !m_frame->loader().client())
+    if (!frame() || !frame()->loader().client())
         return 0;
-    return m_frame->loader().client()->backForwardLength();
+    return frame()->loader().client()->backForwardLength();
 }
 
 SerializedScriptValue* History::state()
 {
     m_lastStateObjectRequested = stateInternal();
     return m_lastStateObjectRequested.get();
 }
 
 SerializedScriptValue* History::stateInternal() const
 {
-    if (!m_frame)
+    if (!frame())
         return 0;
 
-    if (HistoryItem* historyItem = m_frame->loader().currentItem())
+    if (HistoryItem* historyItem = frame()->loader().currentItem())
         return historyItem->stateObject();
 
     return 0;
 }
 
 void History::setScrollRestoration(const String& value)
 {
     ASSERT(value == "manual"  || value == "auto");
-    if (!m_frame || !m_frame->loader().client())
+    if (!frame() || !frame()->loader().client())
         return;
 
     HistoryScrollRestorationType scrollRestoration = value == "manual" ? ScrollRestorationManual : ScrollRestorationAuto;
     if (scrollRestoration == scrollRestorationInternal())
         return;
 
-    if (HistoryItem* historyItem = m_frame->loader().currentItem()) {
+    if (HistoryItem* historyItem = frame()->loader().currentItem()) {
         historyItem->setScrollRestorationType(scrollRestoration);
-        m_frame->loader().client()->didUpdateCurrentHistoryItem();
+        frame()->loader().client()->didUpdateCurrentHistoryItem();
     }
 }
 
 String History::scrollRestoration()
 {
     return scrollRestorationInternal() == ScrollRestorationManual ? "manual" : "auto";
 }
 
 HistoryScrollRestorationType History::scrollRestorationInternal() const
 {
-    if (m_frame) {
-        if (HistoryItem* historyItem = m_frame->loader().currentItem())
+    if (frame()) {
+        if (HistoryItem* historyItem = frame()->loader().currentItem())
             return historyItem->scrollRestorationType();
     }
 
     return ScrollRestorationAuto;
 }
 
 bool History::stateChanged() const
 {
     return m_lastStateObjectRequested != stateInternal();
 }
 
 bool History::isSameAsCurrentState(SerializedScriptValue* state) const
 {
     return state == stateInternal();
 }
 
 void History::back(ExecutionContext* context)
 {
     go(context, -1);
 }
 
 void History::forward(ExecutionContext* context)
 {
     go(context, 1);
 }
 
 void History::go(ExecutionContext* context, int delta)
 {
-    if (!m_frame || !m_frame->loader().client())
+    if (!frame() || !frame()->loader().client())
         return;
 
     ASSERT(isMainThread());
     Document* activeDocument = toDocument(context);
     if (!activeDocument)
         return;
 
-    if (!activeDocument->frame() || !activeDocument->frame()->canNavigate(*m_frame))
+    if (!activeDocument->frame() || !activeDocument->frame()->canNavigate(*frame()))
         return;
     if (!NavigationDisablerForUnload::isNavigationAllowed())
         return;
 
     // We intentionally call reload() for the current frame if delta is zero.
     // Otherwise, navigation happens on the root frame.
     // This behavior is designed in the following spec.
     // https://html.spec.whatwg.org/multipage/browsers.html#dom-history-go
     if (delta)
-        m_frame->loader().client()->navigateBackForward(delta);
+        frame()->loader().client()->navigateBackForward(delta);
     else
-        m_frame->reload(FrameLoadTypeReload, ClientRedirectPolicy::ClientRedirect);
+        frame()->reload(FrameLoadTypeReload, ClientRedirectPolicy::ClientRedirect);
 }
 
 KURL History::urlForState(const String& urlString)
 {
-    Document* document = m_frame->document();
+    Document* document = frame()->document();
 
     if (urlString.isNull())
         return document->url();
     if (urlString.isEmpty())
         return document->baseURL();
 
     return KURL(document->baseURL(), urlString);
 }
 
 bool History::canChangeToUrl(const KURL& url, SecurityOrigin* documentOrigin, const KURL& documentURL)
@@ skipping 15 matching lines @@
 
     RefPtr<SecurityOrigin> requestedOrigin = SecurityOrigin::create(url);
     if (requestedOrigin->isUnique() || !requestedOrigin->isSameSchemeHostPort(documentOrigin))
         return false;
 
     return true;
 }
 
 void History::stateObjectAdded(PassRefPtr<SerializedScriptValue> data, const String& /* title */, const String& urlString, HistoryScrollRestorationType restorationType, FrameLoadType type, ExceptionState& exceptionState)
 {
-    if (!m_frame || !m_frame->page() || !m_frame->loader().documentLoader())
+    if (!frame() || !frame()->page() || !frame()->loader().documentLoader())
         return;
 
     KURL fullURL = urlForState(urlString);
-    if (!canChangeToUrl(fullURL, m_frame->document()->getSecurityOrigin(), m_frame->document()->url())) {
+    if (!canChangeToUrl(fullURL, frame()->document()->getSecurityOrigin(), frame()->document()->url())) {
         // We can safely expose the URL to JavaScript, as a) no redirection takes place: JavaScript already had this URL, b) JavaScript can only access a same-origin History object.
-        exceptionState.throwSecurityError("A history state object with URL '" + fullURL.elidedString() + "' cannot be created in a document with origin '" + m_frame->document()->getSecurityOrigin()->toString() + "' and URL '" + m_frame->document()->url().elidedString() + "'.");
+        exceptionState.throwSecurityError("A history state object with URL '" + fullURL.elidedString() + "' cannot be created in a document with origin '" + frame()->document()->getSecurityOrigin()->toString() + "' and URL '" + frame()->document()->url().elidedString() + "'.");
         return;
     }
 
-    m_frame->loader().updateForSameDocumentNavigation(fullURL, SameDocumentNavigationHistoryApi, std::move(data), restorationType, type, m_frame->document());
+    frame()->loader().updateForSameDocumentNavigation(fullURL, SameDocumentNavigationHistoryApi, std::move(data), restorationType, type, frame()->document());
 }
 
 } // namespace blink