Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Unified Diff: third_party/WebKit/Source/modules/screen_orientation/ScreenOrientation.cpp

Issue 2375873003: Make DOMWindowProperty::m_frame private (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/screen_orientation/ScreenOrientation.cpp
diff --git a/third_party/WebKit/Source/modules/screen_orientation/ScreenOrientation.cpp b/third_party/WebKit/Source/modules/screen_orientation/ScreenOrientation.cpp
index 16bee9eb8d21893e85639e12926578ae17541e18..7d8d515efa0aa90fc6992797289b7783f78f6d0b 100644
--- a/third_party/WebKit/Source/modules/screen_orientation/ScreenOrientation.cpp
+++ b/third_party/WebKit/Source/modules/screen_orientation/ScreenOrientation.cpp
@@ -125,9 +125,9 @@ const WTF::AtomicString& ScreenOrientation::interfaceName() const
ExecutionContext* ScreenOrientation::getExecutionContext() const
{
- if (!m_frame)
+ if (!frame())
return 0;
- return m_frame->document();
+ return frame()->document();
}
String ScreenOrientation::type() const
@@ -155,7 +155,7 @@ ScriptPromise ScreenOrientation::lock(ScriptState* state, const AtomicString& lo
ScriptPromiseResolver* resolver = ScriptPromiseResolver::create(state);
ScriptPromise promise = resolver->promise();
- Document* document = m_frame ? m_frame->document() : 0;
+ Document* document = frame() ? frame()->document() : 0;
if (!document || !controller()) {
DOMException* exception = DOMException::create(InvalidStateError, "The object is no longer associated to a document.");
@@ -183,10 +183,10 @@ void ScreenOrientation::unlock()
ScreenOrientationController* ScreenOrientation::controller()
{
- if (!m_frame)
+ if (!frame())
return 0;
- return ScreenOrientationController::from(*m_frame);
+ return ScreenOrientationController::from(*frame());
}
DEFINE_TRACE(ScreenOrientation)
« no previous file with comments | « third_party/WebKit/Source/modules/plugins/DOMPluginArray.cpp ('k') | third_party/WebKit/Source/modules/storage/Storage.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698