Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(521)

Issue 2370253002: Mark calls of visible{Start,End} with dirty layout deprecated (Closed)

Created:
4 years, 2 months ago by Xiaocheng
Modified:
4 years, 2 months ago
Reviewers:
yosin_UTC9
CC:
blink-reviews, chromium-reviews, groby+blinkspell_chromium.org, timvolodine
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Mark calls of visible{Start,End} with dirty layout deprecated This patch marks the current VisibleSelection::visible{Start,End} deprecated because they updates layout synchronously, and introduces the new desired versions that requires clean layout. This patch also ensures that call of these two functions from outside editing commands are done with clean layout, and make the calls in editing commands switch to the deprecated versions. BUG=647219 Committed: https://crrev.com/57eca1337e14e60d21b126d828c6c5e2845cd620 Cr-Commit-Position: refs/heads/master@{#421413}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+68 lines, -55 lines) Patch
M third_party/WebKit/Source/core/editing/FrameSelection.cpp View 1 chunk +5 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/editing/VisibleSelection.h View 1 chunk +8 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/editing/commands/ApplyBlockElementCommand.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/editing/commands/BreakBlockquoteCommand.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/editing/commands/CompositeEditCommand.cpp View 5 chunks +6 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/editing/commands/DeleteSelectionCommand.cpp View 2 chunks +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/editing/commands/EditorCommand.cpp View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/editing/commands/IndentOutdentCommand.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/editing/commands/InsertLineBreakCommand.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/editing/commands/InsertListCommand.cpp View 5 chunks +9 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/core/editing/commands/InsertParagraphSeparatorCommand.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/editing/commands/InsertTextCommand.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/editing/commands/ReplaceSelectionCommand.cpp View 7 chunks +11 lines, -11 lines 0 comments Download
M third_party/WebKit/Source/core/editing/commands/TypingCommand.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/editing/spellcheck/SpellChecker.cpp View 2 chunks +7 lines, -7 lines 0 comments Download

Messages

Total messages: 14 (8 generated)
Xiaocheng
PTAL. It doesn't appear to be one month's work :)
4 years, 2 months ago (2016-09-27 12:27:57 UTC) #5
yosin_UTC9
lgtm
4 years, 2 months ago (2016-09-28 01:10:48 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2370253002/1
4 years, 2 months ago (2016-09-28 01:11:21 UTC) #10
yosin_UTC9
On 2016/09/27 at 12:27:57, xiaochengh wrote: > PTAL. > > It doesn't appear to be ...
4 years, 2 months ago (2016-09-28 01:11:48 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-09-28 01:17:38 UTC) #12
commit-bot: I haz the power
4 years, 2 months ago (2016-09-28 01:20:54 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/57eca1337e14e60d21b126d828c6c5e2845cd620
Cr-Commit-Position: refs/heads/master@{#421413}

Powered by Google App Engine
This is Rietveld 408576698