third_party/WebKit/Source/core/editing/commands/TypingCommand.cpp - Issue 2370253002: Mark calls of visible{Start,End} with dirty layout deprecated

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/commands/TypingCommand.cpp

Issue 2370253002: Mark calls of visible{Start,End} with dirty layout deprecated (Closed)

Patch Set: Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/editing/commands/ReplaceSelectionCommand.cpp ('k') | third_party/WebKit/Source/core/editing/spellcheck/SpellChecker.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/editing/commands/TypingCommand.cpp

diff --git a/third_party/WebKit/Source/core/editing/commands/TypingCommand.cpp b/third_party/WebKit/Source/core/editing/commands/TypingCommand.cpp

index 8450f5cac749066cd9300b7c694f8b6c467094a2..59505bc8887f4fb89a063ac5308504a1dfc4d5e8 100644

--- a/third_party/WebKit/Source/core/editing/commands/TypingCommand.cpp

+++ b/third_party/WebKit/Source/core/editing/commands/TypingCommand.cpp

@@ -495,7 +495,7 @@ void TypingCommand::deleteKeyPressed(TextGranularity granularity, bool killRing,

if (killRing && selectionModifier.selection().isCaret() && granularity != CharacterGranularity)

selectionModifier.modify(FrameSelection::AlterationExtend, DirectionBackward, CharacterGranularity);

- VisiblePosition visibleStart(endingSelection().visibleStart());

+ VisiblePosition visibleStart(endingSelection().visibleStartDeprecated());

if (previousPositionOf(visibleStart, CannotCrossEditingBoundary).isNull()) {

// When the caret is at the start of the editable area in an empty list item, break out of the list item.

bool breakOutOfEmptyListItemResult = breakOutOfEmptyListItem(editingState);

@@ -605,7 +605,7 @@ void TypingCommand::forwardDeleteKeyPressed(TextGranularity granularity, bool ki

selectionModifier.modify(FrameSelection::AlterationExtend, DirectionForward, CharacterGranularity);

Position downstreamEnd = mostForwardCaretPosition(endingSelection().end());

- VisiblePosition visibleEnd = endingSelection().visibleEnd();

+ VisiblePosition visibleEnd = endingSelection().visibleEndDeprecated();

Node* enclosingTableCell = enclosingNodeOfType(visibleEnd.deepEquivalent(), &isTableCell);

if (enclosingTableCell && visibleEnd.deepEquivalent() == VisiblePosition::lastPositionInNode(enclosingTableCell).deepEquivalent())

return;

@@ -619,7 +619,7 @@ void TypingCommand::forwardDeleteKeyPressed(TextGranularity granularity, bool ki

}

// deleting to end of paragraph when at end of paragraph needs to merge the next paragraph (if any)

- if (granularity == ParagraphBoundary && selectionModifier.selection().isCaret() && isEndOfParagraphDeprecated(selectionModifier.selection().visibleEnd()))

+ if (granularity == ParagraphBoundary && selectionModifier.selection().isCaret() && isEndOfParagraphDeprecated(selectionModifier.selection().visibleEndDeprecated()))

selectionModifier.modify(FrameSelection::AlterationExtend, DirectionForward, CharacterGranularity);

selectionToDelete = selectionModifier.selection();