Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Side by Side Diff: third_party/WebKit/Source/core/editing/FrameSelection.cpp

Issue 2370253002: Mark calls of visible{Start,End} with dirty layout deprecated (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/editing/VisibleSelection.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2004, 2008, 2009, 2010 Apple Inc. All rights reserved. 2 * Copyright (C) 2004, 2008, 2009, 2010 Apple Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
(...skipping 768 matching lines...) Expand 10 before | Expand all | Expand 10 after
779 Frame* parent = m_frame->tree().parent(); 779 Frame* parent = m_frame->tree().parent();
780 if (!parent) 780 if (!parent)
781 return; 781 return;
782 Page* page = m_frame->page(); 782 Page* page = m_frame->page();
783 if (!page) 783 if (!page)
784 return; 784 return;
785 785
786 // Check if the selection contains the entire frame contents; if not, then t here is nothing to do. 786 // Check if the selection contains the entire frame contents; if not, then t here is nothing to do.
787 if (!isRange()) 787 if (!isRange())
788 return; 788 return;
789
790 // TODO(xiaochengh): The use of updateStyleAndLayoutIgnorePendingStylesheets
791 // needs to be audited. See http://crbug.com/590369 for more details.
792 document().updateStyleAndLayoutIgnorePendingStylesheets();
793
789 if (!isStartOfDocument(selection().visibleStart())) 794 if (!isStartOfDocument(selection().visibleStart()))
790 return; 795 return;
791 if (!isEndOfDocument(selection().visibleEnd())) 796 if (!isEndOfDocument(selection().visibleEnd()))
792 return; 797 return;
793 798
794 // FIXME: This is not yet implemented for cross-process frame relationships. 799 // FIXME: This is not yet implemented for cross-process frame relationships.
795 if (!parent->isLocalFrame()) 800 if (!parent->isLocalFrame())
796 return; 801 return;
797 802
798 // Get to the <iframe> or <frame> (or even <object>) element in the parent f rame. 803 // Get to the <iframe> or <frame> (or even <object>) element in the parent f rame.
(...skipping 593 matching lines...) Expand 10 before | Expand all | Expand 10 after
1392 1397
1393 void showTree(const blink::FrameSelection* sel) 1398 void showTree(const blink::FrameSelection* sel)
1394 { 1399 {
1395 if (sel) 1400 if (sel)
1396 sel->showTreeForThis(); 1401 sel->showTreeForThis();
1397 else 1402 else
1398 LOG(INFO) << "Cannot showTree for <null> FrameSelection."; 1403 LOG(INFO) << "Cannot showTree for <null> FrameSelection.";
1399 } 1404 }
1400 1405
1401 #endif 1406 #endif
OLDNEW
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/editing/VisibleSelection.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698