Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Unified Diff: third_party/WebKit/Source/core/editing/commands/InsertLineBreakCommand.cpp

Issue 2370253002: Mark calls of visible{Start,End} with dirty layout deprecated (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/editing/commands/InsertLineBreakCommand.cpp
diff --git a/third_party/WebKit/Source/core/editing/commands/InsertLineBreakCommand.cpp b/third_party/WebKit/Source/core/editing/commands/InsertLineBreakCommand.cpp
index 53a1fcf6c87eaa8f7e8418921e7269bb14282ba7..24f4fb5d87abd4ecb0920d637bdf40399d5338b9 100644
--- a/third_party/WebKit/Source/core/editing/commands/InsertLineBreakCommand.cpp
+++ b/third_party/WebKit/Source/core/editing/commands/InsertLineBreakCommand.cpp
@@ -73,7 +73,7 @@ void InsertLineBreakCommand::doApply(EditingState* editingState)
if (!selection.isNonOrphanedCaretOrRange())
return;
- VisiblePosition caret(selection.visibleStart());
+ VisiblePosition caret(selection.visibleStartDeprecated());
// FIXME: If the node is hidden, we should still be able to insert text.
// For now, we return to avoid a crash. https://bugs.webkit.org/show_bug.cgi?id=40342
if (caret.isNull())
@@ -192,7 +192,7 @@ void InsertLineBreakCommand::doApply(EditingState* editingState)
// before the line break (if the line break is at the end of a block it isn't selectable).
// So, this next call sets the endingSelection() to a caret just after the line break
// that we inserted, or just before it if it's at the end of a block.
- setEndingSelection(endingSelection().visibleEnd());
+ setEndingSelection(endingSelection().visibleEndDeprecated());
}
rebalanceWhitespace();

Powered by Google App Engine
This is Rietveld 408576698