third_party/WebKit/Source/core/editing/commands/ApplyBlockElementCommand.cpp - Issue 2370253002: Mark calls of visible{Start,End} with dirty layout deprecated

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/commands/ApplyBlockElementCommand.cpp

Issue 2370253002: Mark calls of visible{Start,End} with dirty layout deprecated (Closed)

Patch Set: Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/editing/VisibleSelection.h ('k') | third_party/WebKit/Source/core/editing/commands/BreakBlockquoteCommand.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/editing/commands/ApplyBlockElementCommand.cpp

diff --git a/third_party/WebKit/Source/core/editing/commands/ApplyBlockElementCommand.cpp b/third_party/WebKit/Source/core/editing/commands/ApplyBlockElementCommand.cpp

index d30fc4ae35b18151cfb990e35a450c778ca90609..eb76b9898a3349727c647a127620d83f97bcce2d 100644

--- a/third_party/WebKit/Source/core/editing/commands/ApplyBlockElementCommand.cpp

+++ b/third_party/WebKit/Source/core/editing/commands/ApplyBlockElementCommand.cpp

@@ -59,8 +59,8 @@ void ApplyBlockElementCommand::doApply(EditingState* editingState)

if (!endingSelection().rootEditableElement())

return;

- VisiblePosition visibleEnd = endingSelection().visibleEnd();

- VisiblePosition visibleStart = endingSelection().visibleStart();

+ VisiblePosition visibleEnd = endingSelection().visibleEndDeprecated();

+ VisiblePosition visibleStart = endingSelection().visibleStartDeprecated();

if (visibleStart.isNull() || visibleStart.isOrphan() || visibleEnd.isNull() || visibleEnd.isOrphan())

return;

@@ -80,8 +80,8 @@ void ApplyBlockElementCommand::doApply(EditingState* editingState)

}

VisibleSelection selection = selectionForParagraphIteration(endingSelection());

- VisiblePosition startOfSelection = selection.visibleStart();

- VisiblePosition endOfSelection = selection.visibleEnd();

+ VisiblePosition startOfSelection = selection.visibleStartDeprecated();

+ VisiblePosition endOfSelection = selection.visibleEndDeprecated();

DCHECK(!startOfSelection.isNull());

DCHECK(!endOfSelection.isNull());

ContainerNode* startScope = nullptr;