third_party/WebKit/Source/core/editing/commands/EditorCommand.cpp - Issue 2370253002: Mark calls of visible{Start,End} with dirty layout deprecated

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/commands/EditorCommand.cpp

Issue 2370253002: Mark calls of visible{Start,End} with dirty layout deprecated (Closed)

Patch Set: Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/editing/commands/EditorCommand.cpp

diff --git a/third_party/WebKit/Source/core/editing/commands/EditorCommand.cpp b/third_party/WebKit/Source/core/editing/commands/EditorCommand.cpp

index 8fe0041f093d33471cfabf899454db4576cb7a4f..888685aed04bd515b5b8670b4ced78122ea86994 100644

--- a/third_party/WebKit/Source/core/editing/commands/EditorCommand.cpp

+++ b/third_party/WebKit/Source/core/editing/commands/EditorCommand.cpp

@@ -396,6 +396,8 @@ static String valueStyle(LocalFrame& frame, CSSPropertyID propertyID)

static TriState stateTextWritingDirection(LocalFrame& frame, WritingDirection direction)

{

+ frame.document()->updateStyleAndLayoutIgnorePendingStylesheets();

bool hasNestedOrMultipleEmbeddings;

WritingDirection selectionDirection = EditingStyle::textDirectionForSelection(frame.selection().selection(),

frame.selection().typingStyle(), hasNestedOrMultipleEmbeddings);