third_party/WebKit/Source/core/editing/commands/InsertTextCommand.cpp - Issue 2370253002: Mark calls of visible{Start,End} with dirty layout deprecated

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/commands/InsertTextCommand.cpp

Issue 2370253002: Mark calls of visible{Start,End} with dirty layout deprecated (Closed)

Patch Set: Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/editing/commands/InsertParagraphSeparatorCommand.cpp ('k') | third_party/WebKit/Source/core/editing/commands/ReplaceSelectionCommand.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/editing/commands/InsertTextCommand.cpp

diff --git a/third_party/WebKit/Source/core/editing/commands/InsertTextCommand.cpp b/third_party/WebKit/Source/core/editing/commands/InsertTextCommand.cpp

index 46e2b6caab627cbb2048593c5f44e9ae7aae9307..e1e94fb875ac252d8a78f430efcaa3edda024005 100644

--- a/third_party/WebKit/Source/core/editing/commands/InsertTextCommand.cpp

+++ b/third_party/WebKit/Source/core/editing/commands/InsertTextCommand.cpp

@@ -101,7 +101,7 @@ bool InsertTextCommand::performTrivialReplace(const String& text, bool selectIns

setEndingSelectionWithoutValidation(start, endPosition);

if (!selectInsertedText)

- setEndingSelection(VisibleSelection(endingSelection().visibleEnd(), endingSelection().isDirectional()));

+ setEndingSelection(VisibleSelection(endingSelection().visibleEndDeprecated(), endingSelection().isDirectional()));

return true;

}

@@ -124,7 +124,7 @@ bool InsertTextCommand::performOverwrite(const String& text, bool selectInserted

Position endPosition = Position(textNode, start.offsetInContainerNode() + text.length());

setEndingSelectionWithoutValidation(start, endPosition);

if (!selectInsertedText)

- setEndingSelection(VisibleSelection(endingSelection().visibleEnd(), endingSelection().isDirectional()));

+ setEndingSelection(VisibleSelection(endingSelection().visibleEndDeprecated(), endingSelection().isDirectional()));

return true;

}

@@ -141,7 +141,7 @@ void InsertTextCommand::doApply(EditingState* editingState)

if (endingSelection().isRange()) {

if (performTrivialReplace(m_text, m_selectInsertedText))

return;

- bool endOfSelectionWasAtStartOfBlock = isStartOfBlock(endingSelection().visibleEnd());

+ bool endOfSelectionWasAtStartOfBlock = isStartOfBlock(endingSelection().visibleEndDeprecated());

deleteSelection(editingState, false, true, false, false);

if (editingState->isAborted())

return;