net: rename BoundNetLog to NetLogWithSource

net: rename BoundNetLog to NetLogWithSource

Patch generated by the following command line:

$ g grep -l BoundNetLog | xargs perl -pi -e 's/BoundNetLog/NetLogWithSource/g'

BUG=475260
TEST=net_unittests
R=eroman@chromium.org
TBR=dtrainor,thestig,oshima,sdefresne,avi,rockot,rogerta,sergeyu

Committed: https://crrev.com/4283411131bf998401985c4b1784ddaa67dac0d7
Cr-Commit-Position: refs/heads/master@{#420320}

[tfarina, 2016-09-19 12:19:32]

The CQ bit was checked by tfarina@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-19 12:19:47]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tfarina, 2016-09-19 13:31:52]

Description was changed from

==========
net: rename BoundNetLog to NetLogWithSource

BUG=475260
TEST=net_unittests
R=eroman@chromium.org
==========

to

==========
net: rename BoundNetLog to NetLogWithSource

Patch generated by the following command line:

$ g grep -l BoundNetLog | xargs perl -pi -e 's/BoundNetLog/NetLogWithSource/g'

BUG=475260
TEST=net_unittests
R=eroman@chromium.org
==========

[commit-bot: I haz the power, 2016-09-19 14:52:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-19 14:52:13]

Dry run: This issue passed the CQ dry run.

[tfarina, 2016-09-20 12:25:03]

Sending for review.

I may still need to fix the using declarations. Haven't look at them yet.

[tfarina, 2016-09-20 15:01:17]

The CQ bit was checked by tfarina@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-20 15:02:22]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-20 15:29:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-20 15:29:23]

Dry run: Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)

[eroman, 2016-09-20 18:09:37]

LGTM -- Okay to TBR the rest once trybots pass (I can retroactively review the
final modifications).

https://codereview.chromium.org/2351513002/diff/60001/content/browser/downloa...
File content/browser/download/download_create_info.cc (right):

https://codereview.chromium.org/2351513002/diff/60001/content/browser/downloa...
content/browser/download/download_create_info.cc:17: const
net::NetLogWithSource& bound_net_log,
Either in this change or a follow-up, we should rename "bound_net_log".

The most obvious translation would be "net_log_with_source", however there is
precedent elsewhere to just call this the shorter "net_log".

My preference would be "net_log", however be aware that a search-replace on this
might cause some conflicts where net_log is already a name.

[tfarina, 2016-09-21 18:17:24]

The CQ bit was checked by tfarina@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-21 18:18:02]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-21 18:23:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-21 18:23:48]

Dry run: Try jobs failed on following builders:
  android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)
  android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...)
  android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)
  cast_shell_android on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)
  chromeos_x86-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_x86-ge...)
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_compile_dbg_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_clobber_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[tfarina, 2016-09-21 19:08:43]

The CQ bit was checked by tfarina@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-21 19:09:08]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-21 19:24:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-21 19:24:57]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)

[tfarina, 2016-09-21 19:41:04]

I'm uploading the last fix, but it take ages on Mac.

Please, TBR + CQ, if it is alright.

https://codereview.chromium.org/2351513002/diff/60001/content/browser/downloa...
File content/browser/download/download_create_info.cc (right):

https://codereview.chromium.org/2351513002/diff/60001/content/browser/downloa...
content/browser/download/download_create_info.cc:17: const
net::NetLogWithSource& bound_net_log,
On 2016/09/20 18:09:36, eroman wrote:
> Either in this change or a follow-up, we should rename "bound_net_log".
> 
> The most obvious translation would be "net_log_with_source", however there is
> precedent elsewhere to just call this the shorter "net_log".
> 
> My preference would be "net_log", however be aware that a search-replace on
this
> might cause some conflicts where net_log is already a name.

Done.

[tfarina, 2016-09-21 19:44:05]

The CQ bit was checked by tfarina@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-21 19:44:26]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-21 20:02:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-21 20:02:55]

Dry run: Try jobs failed on following builders:
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)
  chromeos_x86-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_x86-ge...)
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[tfarina, 2016-09-21 20:15:21]

The CQ bit was checked by tfarina@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-21 20:15:56]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-21 23:03:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-21 23:03:08]

Dry run: This issue passed the CQ dry run.

[tfarina, 2016-09-22 13:09:33]

Eric, I'm going to tbr the top-level directory owners as I got green trybots
this time and to not let get it stale.

I will happily address any feedback received in a followup.

[tfarina, 2016-09-22 13:18:29]

tfarina@chromium.org changed reviewers:
+ avi@chromium.org, dtrainor@chromium.org, oshima@chromium.org,
rockot@chromium.org, rogerta@chromium.org, sdefresne@chromium.org,
sergeyu@chromium.org, thestig@chromium.org

[tfarina, 2016-09-22 13:18:32]

TBRing owners for directories other than net/.

blimp - dtrainor
chrome - thestig
chromeos - oshima
components - sdefresne
content - avi
extensions - rockot
google_apis - rogerta
jingle & remoting - sergeyu

[tfarina, 2016-09-22 13:19:32]

Description was changed from

==========
net: rename BoundNetLog to NetLogWithSource

Patch generated by the following command line:

$ g grep -l BoundNetLog | xargs perl -pi -e 's/BoundNetLog/NetLogWithSource/g'

BUG=475260
TEST=net_unittests
R=eroman@chromium.org
==========

to

==========
net: rename BoundNetLog to NetLogWithSource

Patch generated by the following command line:

$ g grep -l BoundNetLog | xargs perl -pi -e 's/BoundNetLog/NetLogWithSource/g'

BUG=475260
TEST=net_unittests
R=eroman@chromium.org
TBR=dtrainor,thestig,oshima,sdefresne,avi,rockot,rogerta,sergeyu
==========

[tfarina, 2016-09-22 13:20:18]

The CQ bit was checked by tfarina@chromium.org

[tfarina, 2016-09-22 13:20:20]

The patchset sent to the CQ was uploaded after l-g-t-m from eroman@chromium.org
Link to the patchset: https://codereview.chromium.org/2351513002/#ps120001
(title: "one more fix, content bound_net_log_")

[commit-bot: I haz the power, 2016-09-22 13:20:31]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sdefresne, 2016-09-22 13:27:18]

lgtm for components/

https://codereview.chromium.org/2351513002/diff/120001/components/data_reduct...
File components/data_reduction_proxy/core/browser/data_reduction_proxy_config.h
(right):

https://codereview.chromium.org/2351513002/diff/120001/components/data_reduct...
components/data_reduction_proxy/core/browser/data_reduction_proxy_config.h:97:
// check.
nit: can you rewrap this comment?

https://codereview.chromium.org/2351513002/diff/120001/components/data_reduct...
components/data_reduction_proxy/core/browser/data_reduction_proxy_config.h:332:
// proxy
nit: can you rewrap this comment?

[commit-bot: I haz the power, 2016-09-22 13:38:41]

Description was changed from

==========
net: rename BoundNetLog to NetLogWithSource

Patch generated by the following command line:

$ g grep -l BoundNetLog | xargs perl -pi -e 's/BoundNetLog/NetLogWithSource/g'

BUG=475260
TEST=net_unittests
R=eroman@chromium.org
TBR=dtrainor,thestig,oshima,sdefresne,avi,rockot,rogerta,sergeyu
==========

to

==========
net: rename BoundNetLog to NetLogWithSource

Patch generated by the following command line:

$ g grep -l BoundNetLog | xargs perl -pi -e 's/BoundNetLog/NetLogWithSource/g'

BUG=475260
TEST=net_unittests
R=eroman@chromium.org
TBR=dtrainor,thestig,oshima,sdefresne,avi,rockot,rogerta,sergeyu
==========

[commit-bot: I haz the power, 2016-09-22 13:38:44]

Committed patchset #11 (id:120001)

[commit-bot: I haz the power, 2016-09-22 13:41:02]

Description was changed from

==========
net: rename BoundNetLog to NetLogWithSource

Patch generated by the following command line:

$ g grep -l BoundNetLog | xargs perl -pi -e 's/BoundNetLog/NetLogWithSource/g'

BUG=475260
TEST=net_unittests
R=eroman@chromium.org
TBR=dtrainor,thestig,oshima,sdefresne,avi,rockot,rogerta,sergeyu
==========

to

==========
net: rename BoundNetLog to NetLogWithSource

Patch generated by the following command line:

$ g grep -l BoundNetLog | xargs perl -pi -e 's/BoundNetLog/NetLogWithSource/g'

BUG=475260
TEST=net_unittests
R=eroman@chromium.org
TBR=dtrainor,thestig,oshima,sdefresne,avi,rockot,rogerta,sergeyu

Committed: https://crrev.com/4283411131bf998401985c4b1784ddaa67dac0d7
Cr-Commit-Position: refs/heads/master@{#420320}
==========

[commit-bot: I haz the power, 2016-09-22 13:41:05]

Patchset 11 (id:??) landed as
https://crrev.com/4283411131bf998401985c4b1784ddaa67dac0d7
Cr-Commit-Position: refs/heads/master@{#420320}

[Avi (use Gerrit), 2016-09-22 14:48:59]

content stampity stamp lgtm

[Lei Zhang, 2016-09-22 17:06:20]

chrome/ gltm

https://codereview.chromium.org/2351513002/diff/120001/chrome/browser/devtool...
File chrome/browser/devtools/devtools_network_transaction.h (right):

https://codereview.chromium.org/2351513002/diff/120001/chrome/browser/devtool...
chrome/browser/devtools/devtools_network_transaction.h:28: class
NetLogWithSource;
alphabetical order

[Lei Zhang, 2016-09-22 17:07:29]

lgtm, even. (hands experienced a race condition?)

[mmenke, 2016-09-22 17:42:28]

On 2016/09/22 17:07:29, Lei Zhang wrote:
> lgtm, even. (hands experienced a race condition?)

Maybe your arm processor just needs an upgrade.