Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(454)

Unified Diff: net/proxy/proxy_service_mojo_unittest.cc

Issue 2351513002: net: rename BoundNetLog to NetLogWithSource (Closed)
Patch Set: one more fix, content bound_net_log_ Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/proxy/proxy_service_mojo_unittest.cc
diff --git a/net/proxy/proxy_service_mojo_unittest.cc b/net/proxy/proxy_service_mojo_unittest.cc
index f3a839642756c07d47861af1d35d2aa9fae8c0d0..7c034109efae3484f4d06bb9f6917f6576071452 100644
--- a/net/proxy/proxy_service_mojo_unittest.cc
+++ b/net/proxy/proxy_service_mojo_unittest.cc
@@ -115,7 +115,7 @@ class LoggingMockHostResolver : public MockHostResolver {
AddressList* addresses,
const CompletionCallback& callback,
std::unique_ptr<Request>* out_req,
- const BoundNetLog& net_log) override {
+ const NetLogWithSource& net_log) override {
net_log.AddEvent(NetLogEventType::HOST_RESOLVER_IMPL_JOB);
return MockHostResolver::Resolve(info, priority, addresses, callback,
out_req, net_log);
@@ -162,7 +162,7 @@ TEST_F(ProxyServiceMojoTest, Basic) {
EXPECT_EQ(ERR_IO_PENDING,
proxy_service_->ResolveProxy(GURL("http://foo"), std::string(),
&info, callback.callback(), nullptr,
- nullptr, BoundNetLog()));
+ nullptr, NetLogWithSource()));
// Proxy script fetcher should have a fetch triggered by the first
// |ResolveProxy()| request.
@@ -180,11 +180,11 @@ TEST_F(ProxyServiceMojoTest, Basic) {
TEST_F(ProxyServiceMojoTest, DnsResolution) {
ProxyInfo info;
TestCompletionCallback callback;
- BoundTestNetLog bound_net_log;
+ BoundTestNetLog test_net_log;
EXPECT_EQ(ERR_IO_PENDING,
proxy_service_->ResolveProxy(GURL("http://foo"), std::string(),
&info, callback.callback(), nullptr,
- nullptr, bound_net_log.bound()));
+ nullptr, test_net_log.bound()));
// Proxy script fetcher should have a fetch triggered by the first
// |ResolveProxy()| request.
@@ -199,7 +199,7 @@ TEST_F(ProxyServiceMojoTest, DnsResolution) {
on_delete_closure_.WaitForResult();
TestNetLogEntry::List entries;
- bound_net_log.GetEntries(&entries);
+ test_net_log.GetEntries(&entries);
// There should be one entry with type TYPE_HOST_RESOLVER_IMPL_JOB.
EXPECT_EQ(1, std::count_if(entries.begin(), entries.end(),
[](const TestNetLogEntry& entry) {
@@ -211,11 +211,11 @@ TEST_F(ProxyServiceMojoTest, DnsResolution) {
TEST_F(ProxyServiceMojoTest, Error) {
ProxyInfo info;
TestCompletionCallback callback;
- BoundTestNetLog bound_net_log;
+ BoundTestNetLog test_net_log;
EXPECT_EQ(ERR_IO_PENDING,
proxy_service_->ResolveProxy(GURL("http://foo"), std::string(),
&info, callback.callback(), nullptr,
- nullptr, bound_net_log.bound()));
+ nullptr, test_net_log.bound()));
// Proxy script fetcher should have a fetch triggered by the first
// |ResolveProxy()| request.
@@ -231,7 +231,7 @@ TEST_F(ProxyServiceMojoTest, Error) {
EXPECT_EQ(0u, mock_host_resolver_.num_resolve());
TestNetLogEntry::List entries;
- bound_net_log.GetEntries(&entries);
+ test_net_log.GetEntries(&entries);
CheckCapturedNetLogEntries(entries);
entries.clear();
net_log_.GetEntries(&entries);
@@ -244,7 +244,7 @@ TEST_F(ProxyServiceMojoTest, ErrorOnInitialization) {
EXPECT_EQ(ERR_IO_PENDING,
proxy_service_->ResolveProxy(GURL("http://foo"), std::string(),
&info, callback.callback(), nullptr,
- nullptr, BoundNetLog()));
+ nullptr, NetLogWithSource()));
// Proxy script fetcher should have a fetch triggered by the first
// |ResolveProxy()| request.

Powered by Google App Engine
This is Rietveld 408576698