Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(660)

Unified Diff: net/socket/client_socket_pool_base.h

Issue 2351513002: net: rename BoundNetLog to NetLogWithSource (Closed)
Patch Set: one more fix, content bound_net_log_ Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/socket/client_socket_pool_base.h
diff --git a/net/socket/client_socket_pool_base.h b/net/socket/client_socket_pool_base.h
index a5e17b380366f513ef37a1590c5c1fa95449ef20..ecd38e347f3eba6b8a015c0b6b2ab3c95cc02f7c 100644
--- a/net/socket/client_socket_pool_base.h
+++ b/net/socket/client_socket_pool_base.h
@@ -84,12 +84,12 @@ class NET_EXPORT_PRIVATE ConnectJob {
RequestPriority priority,
ClientSocketPool::RespectLimits respect_limits,
Delegate* delegate,
- const BoundNetLog& net_log);
+ const NetLogWithSource& net_log);
virtual ~ConnectJob();
// Accessors
const std::string& group_name() const { return group_name_; }
- const BoundNetLog& net_log() { return net_log_; }
+ const NetLogWithSource& net_log() { return net_log_; }
// Releases ownership of the underlying socket to the caller.
// Returns the released socket, or NULL if there was a connection
@@ -115,7 +115,7 @@ class NET_EXPORT_PRIVATE ConnectJob {
return connect_timing_;
}
- const BoundNetLog& net_log() const { return net_log_; }
+ const NetLogWithSource& net_log() const { return net_log_; }
protected:
RequestPriority priority() const { return priority_; }
@@ -148,7 +148,7 @@ class NET_EXPORT_PRIVATE ConnectJob {
base::OneShotTimer timer_;
Delegate* delegate_;
std::unique_ptr<StreamSocket> socket_;
- BoundNetLog net_log_;
+ NetLogWithSource net_log_;
// A ConnectJob is idle until Connect() has been called.
bool idle_;
@@ -181,7 +181,7 @@ class NET_EXPORT_PRIVATE ClientSocketPoolBaseHelper
RequestPriority priority,
ClientSocketPool::RespectLimits respect_limits,
Flags flags,
- const BoundNetLog& net_log);
+ const NetLogWithSource& net_log);
virtual ~Request();
@@ -192,7 +192,7 @@ class NET_EXPORT_PRIVATE ClientSocketPoolBaseHelper
return respect_limits_;
}
Flags flags() const { return flags_; }
- const BoundNetLog& net_log() const { return net_log_; }
+ const NetLogWithSource& net_log() const { return net_log_; }
// TODO(eroman): Temporary until crbug.com/467797 is solved.
void CrashIfInvalid() const;
@@ -210,7 +210,7 @@ class NET_EXPORT_PRIVATE ClientSocketPoolBaseHelper
const RequestPriority priority_;
const ClientSocketPool::RespectLimits respect_limits_;
const Flags flags_;
- const BoundNetLog net_log_;
+ const NetLogWithSource net_log_;
// TODO(eroman): Temporary until crbug.com/467797 is solved.
Liveness liveness_ = ALIVE;
@@ -547,7 +547,7 @@ class NET_EXPORT_PRIVATE ClientSocketPoolBaseHelper
ClientSocketHandle* handle,
base::TimeDelta time_idle,
Group* group,
- const BoundNetLog& net_log);
+ const NetLogWithSource& net_log);
// Adds |socket| to the list of idle sockets for |group|.
void AddIdleSocket(std::unique_ptr<StreamSocket> socket, Group* group);
@@ -668,7 +668,7 @@ class ClientSocketPoolBase {
ClientSocketPool::RespectLimits respect_limits,
internal::ClientSocketPoolBaseHelper::Flags flags,
const scoped_refptr<SocketParams>& params,
- const BoundNetLog& net_log)
+ const NetLogWithSource& net_log)
: internal::ClientSocketPoolBaseHelper::Request(handle,
callback,
priority,
@@ -741,7 +741,7 @@ class ClientSocketPoolBase {
ClientSocketPool::RespectLimits respect_limits,
ClientSocketHandle* handle,
const CompletionCallback& callback,
- const BoundNetLog& net_log) {
+ const NetLogWithSource& net_log) {
std::unique_ptr<const Request> request(new Request(
handle, callback, priority, respect_limits,
internal::ClientSocketPoolBaseHelper::NORMAL, params, net_log));
@@ -754,7 +754,7 @@ class ClientSocketPoolBase {
void RequestSockets(const std::string& group_name,
const scoped_refptr<SocketParams>& params,
int num_sockets,
- const BoundNetLog& net_log) {
+ const NetLogWithSource& net_log) {
const Request request(nullptr /* no handle */, CompletionCallback(), IDLE,
ClientSocketPool::RespectLimits::ENABLED,
internal::ClientSocketPoolBaseHelper::NO_IDLE_SOCKETS,

Powered by Google App Engine
This is Rietveld 408576698