Issue 23513085: Incorporating review feedback from https://codereview.chromium.org/24294002/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 23513085: Incorporating review feedback from https://codereview.chromium.org/24294002/ (Closed)

Created:
7 years, 3 months ago by blois

Modified:
7 years, 2 months ago

Reviewers:
siva

CC:
reviews+dom_dartlang.org, vsm, rmacnak

Base URL:
svn://svn.chromium.org/multivm/trunk/webkit

Visibility:
Public.

More Reviews

Description

Incorporating review feedback from https://codereview.chromium.org/24294002/ BUG=

Patch Set 1 : #

Total comments: 1

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+31 lines, -16 lines)			Patch
M	Source/bindings/dart/DartCustomElementBinding.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/bindings/dart/DartCustomElementWrapper.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/bindings/dart/DartDOMWrapper.h	View	2 chunks	+7 lines, -7 lines	0 comments	Download
M	Source/bindings/dart/DartUtilities.h	View	2 chunks	+2 lines, -1 line	1 comment	Download
M	Source/bindings/dart/DartUtilities.cpp	View	2 chunks	+17 lines, -3 lines	0 comments	Download
M	Source/bindings/dart/custom/DartDocumentCustom.cpp	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	Source/bindings/dart/gyp/scripts/massage_factories.py	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

siva

lgtm https://codereview.chromium.org/23513085/diff/3001/Source/bindings/dart/DartUtilities.h File Source/bindings/dart/DartUtilities.h (right): https://codereview.chromium.org/23513085/diff/3001/Source/bindings/dart/DartUtilities.h#newcode550 Source/bindings/dart/DartUtilities.h:550: static bool objectIsClass(Dart_Handle, Dart_Handle cls); In the dart ...

7 years, 3 months ago (2013-09-20 23:18:54 UTC) #2

Can we close this CL?

Expand Messages | Collapse Messages