Source/bindings/dart/gyp/scripts/massage_factories.py - Issue 23513085: Incorporating review feedback from https://codereview.chromium.org/24294002/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/dart/gyp/scripts/massage_factories.py

Issue 23513085: Incorporating review feedback from https://codereview.chromium.org/24294002/ (Closed) Base URL: svn://svn.chromium.org/multivm/trunk/webkit

Patch Set: Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/bindings/dart/gyp/scripts/massage_factories.py

diff --git a/Source/bindings/dart/gyp/scripts/massage_factories.py b/Source/bindings/dart/gyp/scripts/massage_factories.py

index 0baa960ee4960db691511578c2a4b553f4ff3cf3..c660a987565eed04f1be50a7bdb4b61d2f03f26a 100644

--- a/Source/bindings/dart/gyp/scripts/massage_factories.py

+++ b/Source/bindings/dart/gyp/scripts/massage_factories.py

@@ -95,7 +95,7 @@ def main(args):

r'return DartCustomElementWrapper<%sElement>::wrap(element, createWrapperFunction);' % tag),

(re.compile(

r'return wrap\(toHTMLUnknownElement\(element\), creationContext, isolate\);'),

- r'return DartHTMLUnknownElement::toDart(toHTMLUnknownElement(element));'),

+ r'return DartHTMLUnknownElement::createWrapper(toHTMLUnknownElement(element));'),

(re.compile(r'createV8%sWrapper' % tag), r'createDart%sWrapper' % tag),

(re.compile(r', v8::Isolate\*( isolate)?'), ''),

(re.compile(r', v8::Handle<v8::Object> creationContext'), ''),

« Source/bindings/dart/DartUtilities.h ('K') | « Source/bindings/dart/custom/DartDocumentCustom.cpp ('k') | no next file » | no next file with comments »