Source/bindings/dart/DartCustomElementBinding.h - Issue 23513085: Incorporating review feedback from https://codereview.chromium.org/24294002/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/dart/DartCustomElementBinding.h

Issue 23513085: Incorporating review feedback from https://codereview.chromium.org/24294002/ (Closed) Base URL: svn://svn.chromium.org/multivm/trunk/webkit

Patch Set: Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/bindings/dart/DartCustomElementBinding.h

diff --git a/Source/bindings/dart/DartCustomElementBinding.h b/Source/bindings/dart/DartCustomElementBinding.h

index 34cba781f288cb8250e1a98c76bf5bb428b927f9..98e702f3c8d142c90d4b92866b942b5529ef58fe 100644

--- a/Source/bindings/dart/DartCustomElementBinding.h

+++ b/Source/bindings/dart/DartCustomElementBinding.h

@@ -42,7 +42,7 @@ class DartCustomElementBinding {

public:

static PassOwnPtr<DartCustomElementBinding> create(Dart_Handle customType);

- Dart_Handle customType() { return Dart_HandleFromPersistent(m_customType); }

+ Dart_PersistentHandle customType() { return m_customType; }

private:

DartCustomElementBinding(Dart_Handle customType);

« no previous file with comments | « no previous file | Source/bindings/dart/DartCustomElementWrapper.cpp » ('j') | Source/bindings/dart/DartUtilities.h » ('J')