Source/bindings/dart/DartCustomElementWrapper.cpp - Issue 23513085: Incorporating review feedback from https://codereview.chromium.org/24294002/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/dart/DartCustomElementWrapper.cpp

Issue 23513085: Incorporating review feedback from https://codereview.chromium.org/24294002/ (Closed) Base URL: svn://svn.chromium.org/multivm/trunk/webkit

Patch Set: Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/bindings/dart/DartCustomElementWrapper.cpp

diff --git a/Source/bindings/dart/DartCustomElementWrapper.cpp b/Source/bindings/dart/DartCustomElementWrapper.cpp

index 8a0be71a8aaa0283c422c5fdf80b8e8fb271b31d..cb59511df539a086fe41ad8adf3fe50c26604756 100644

--- a/Source/bindings/dart/DartCustomElementWrapper.cpp

+++ b/Source/bindings/dart/DartCustomElementWrapper.cpp

@@ -97,7 +97,7 @@ Dart_Handle DartCustomElementWrapper<HTMLElement>::upgradeDartWrapper(HTMLElemen

{

DartDOMData* domData = DartDOMData::current();

DartCustomElementBinding* binding = domData->customElementBinding(CustomElement::definitionFor(element));

- Dart_Handle customType = binding->customType();

+ Dart_Handle customType = Dart_HandleFromPersistent(binding->customType());

ASSERT(!Dart_IsError(customType));

Dart_WeakPersistentHandle oldInstance = DartDOMWrapper::lookupWrapper(DartHTMLElement::isNode, reinterpret_cast<HTMLElement*>(element));

« no previous file with comments | « Source/bindings/dart/DartCustomElementBinding.h ('k') | Source/bindings/dart/DartDOMWrapper.h » ('j') | Source/bindings/dart/DartUtilities.h » ('J')