Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(170)

Unified Diff: Source/bindings/dart/DartDOMWrapper.h

Issue 23513085: Incorporating review feedback from https://codereview.chromium.org/24294002/ (Closed) Base URL: svn://svn.chromium.org/multivm/trunk/webkit
Patch Set: Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/bindings/dart/DartDOMWrapper.h
diff --git a/Source/bindings/dart/DartDOMWrapper.h b/Source/bindings/dart/DartDOMWrapper.h
index 8cc93126124a1d7a0940a1ff01b534d81c308c5b..18ebeed0187095276c5caf9157f80f7c4f71b4c5 100644
--- a/Source/bindings/dart/DartDOMWrapper.h
+++ b/Source/bindings/dart/DartDOMWrapper.h
@@ -201,6 +201,13 @@ public:
static Dart_Handle exceptionCodeToDartException(ExceptionCode);
static Dart_Handle exceptionCodeToDartException(DartExceptionState&);
+ template <class BindingsClass>
+ static Dart_Handle dartClass()
+ {
+ return dartClass(BindingsClass::dartImplementationClassName,
+ BindingsClass::dartImplementationLibraryName, BindingsClass::dartClassId);
+ }
+
private:
enum NativeFieldIndices {
kNativeImplementationIndex = 0,
@@ -210,13 +217,6 @@ private:
static Dart_Handle dartClass(const char* dartImplementationClassName,
const char* dartImplementationLibraryName, intptr_t classIndex);
- template <class BindingsClass>
- static Dart_Handle dartClass()
- {
- return dartClass(BindingsClass::dartImplementationClassName,
- BindingsClass::dartImplementationLibraryName, BindingsClass::dartClassId);
- }
-
static void writeNativePointer(Dart_Handle wrapper, int index, void* pointer)
{
DartApiScope scope;

Powered by Google App Engine
This is Rietveld 408576698