Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(202)

Side by Side Diff: Source/bindings/dart/gyp/scripts/massage_factories.py

Issue 23513085: Incorporating review feedback from https://codereview.chromium.org/24294002/ (Closed) Base URL: svn://svn.chromium.org/multivm/trunk/webkit
Patch Set: Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 #!/usr/bin/python 1 #!/usr/bin/python
2 # 2 #
3 # Copyright (C) 2011 Google Inc. All rights reserved. 3 # Copyright (C) 2011 Google Inc. All rights reserved.
4 # 4 #
5 # Redistribution and use in source and binary forms, with or without 5 # Redistribution and use in source and binary forms, with or without
6 # modification, are permitted provided that the following conditions are 6 # modification, are permitted provided that the following conditions are
7 # met: 7 # met:
8 # 8 #
9 # * Redistributions of source code must retain the above copyright 9 # * Redistributions of source code must retain the above copyright
10 # notice, this list of conditions and the following disclaimer. 10 # notice, this list of conditions and the following disclaimer.
(...skipping 77 matching lines...) Expand 10 before | Expand all | Expand 10 after
88 r'= createV8HTMLDirectWrapper;'), 88 r'= createV8HTMLDirectWrapper;'),
89 r'= DartDOMWrapper::createWrapper<DartHTMLElement>;'), 89 r'= DartDOMWrapper::createWrapper<DartHTMLElement>;'),
90 (re.compile( 90 (re.compile(
91 r'#include "bindings/v8/CustomElementHelpers.h"'), 91 r'#include "bindings/v8/CustomElementHelpers.h"'),
92 r'#include "bindings/v8/CustomElementHelpers.h"\n#include "bindings/ dart/DartCustomElement.h"'), 92 r'#include "bindings/v8/CustomElementHelpers.h"\n#include "bindings/ dart/DartCustomElement.h"'),
93 (re.compile( 93 (re.compile(
94 r'return CustomElementWrapper<%sElement, V8%sElement>::wrap\(element , creationContext, isolate, createWrapperFunction\);' % (tag, tag)), 94 r'return CustomElementWrapper<%sElement, V8%sElement>::wrap\(element , creationContext, isolate, createWrapperFunction\);' % (tag, tag)),
95 r'return DartCustomElementWrapper<%sElement>::wrap(element, createWr apperFunction);' % tag), 95 r'return DartCustomElementWrapper<%sElement>::wrap(element, createWr apperFunction);' % tag),
96 (re.compile( 96 (re.compile(
97 r'return wrap\(toHTMLUnknownElement\(element\), creationContext, iso late\);'), 97 r'return wrap\(toHTMLUnknownElement\(element\), creationContext, iso late\);'),
98 r'return DartHTMLUnknownElement::toDart(toHTMLUnknownElement(element ));'), 98 r'return DartHTMLUnknownElement::createWrapper(toHTMLUnknownElement( element));'),
99 (re.compile(r'createV8%sWrapper' % tag), r'createDart%sWrapper' % tag), 99 (re.compile(r'createV8%sWrapper' % tag), r'createDart%sWrapper' % tag),
100 (re.compile(r', v8::Isolate\*( isolate)?'), ''), 100 (re.compile(r', v8::Isolate\*( isolate)?'), ''),
101 (re.compile(r', v8::Handle<v8::Object> creationContext'), ''), 101 (re.compile(r', v8::Handle<v8::Object> creationContext'), ''),
102 (re.compile(r'v8::Handle<v8::Object>'), 'Dart_Handle'), 102 (re.compile(r'v8::Handle<v8::Object>'), 'Dart_Handle'),
103 (re.compile(r'findSVGTagNameOfV8Type\(const WrapperTypeInfo\* type\)'), 'findSVGTagNameOfDartType(Dart_Handle type)'), 103 (re.compile(r'findSVGTagNameOfV8Type\(const WrapperTypeInfo\* type\)'), 'findSVGTagNameOfDartType(Dart_Handle type)'),
104 (re.compile(r'findHTMLTagNameOfV8Type\(const WrapperTypeInfo\* type\)'), 'findHTMLTagNameOfDartType(Dart_Handle type)'), 104 (re.compile(r'findHTMLTagNameOfV8Type\(const WrapperTypeInfo\* type\)'), 'findHTMLTagNameOfDartType(Dart_Handle type)'),
105 (re.compile(r'V8CustomElement'), 'DartCustomElement'), 105 (re.compile(r'V8CustomElement'), 'DartCustomElement'),
106 (re.compile(r'\s*map.set\(WrapperTypeTraits.*\n'), ''), 106 (re.compile(r'\s*map.set\(WrapperTypeTraits.*\n'), ''),
107 (re.compile(r'HashMap<const WrapperTypeInfo\*, const QualifiedName\*>'), 'HashMap<Dart_Handle, const QualifiedName*>'), 107 (re.compile(r'HashMap<const WrapperTypeInfo\*, const QualifiedName\*>'), 'HashMap<Dart_Handle, const QualifiedName*>'),
108 ]) 108 ])
109 109
110 return 0 110 return 0
111 111
112 if __name__ == '__main__': 112 if __name__ == '__main__':
113 sys.exit(main(sys.argv)) 113 sys.exit(main(sys.argv))
OLDNEW
« Source/bindings/dart/DartUtilities.h ('K') | « Source/bindings/dart/custom/DartDocumentCustom.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698