Issue 235123002: Should throw TypeError instead of TypeMismatchError (modules)

Created:
6 years, 8 months ago by zino

Modified:
5 years, 6 months ago

Reviewers:
haraken

CC:
blink-reviews, tzik, philipj_slow, nhiroki, kinuko, feature-media-reviews_chromium.org, tommyw+watchlist_chromium.org, eric.carlson_apple.com

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Visibility:
Public.

Should throw TypeError instead of TypeMismatchError (modules) TypeMismatchError is already deprecated. We should throw TypeError instead of TypeMismatchError when the given argument is mismatched. This CL affects (Source/modules/*) and some layout tests. This aligns behavior with WebIDL, Gecko and Trident. Additional Information: https://www.w3.org/Bugs/Public/show_bug.cgi?id=19898 https://www.w3.org/Bugs/Public/show_bug.cgi?id=19921 https://bugs.webkit.org/show_bug.cgi?id=101604 BUG=270033

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+25 lines, -25 lines)			Patch
M	LayoutTests/crypto/random-values-types-expected.txt	View		1 chunk	+3 lines, -3 lines	0 comments	Download
M	LayoutTests/crypto/worker-random-values-types-expected.txt	View		1 chunk	+3 lines, -3 lines	0 comments	Download
M	LayoutTests/fast/mediastream/RTCIceCandidate-expected.txt	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download
M	LayoutTests/fast/mediastream/RTCSessionDescription-expected.txt	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/modules/crypto/Crypto.cpp	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	Source/modules/encryptedmedia/HTMLMediaElementEncryptedMedia.cpp	View		1 chunk	+1 line, -1 line	0 comments	Download
M	Source/modules/filesystem/FileWriterSync.cpp	View		1 chunk	+1 line, -1 line	0 comments	Download
M	Source/modules/mediastream/MediaStream.cpp	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	Source/modules/mediastream/RTCDataChannel.cpp	View		1 chunk	+1 line, -1 line	0 comments	Download
M	Source/modules/mediastream/RTCIceCandidate.cpp	View		1 chunk	+1 line, -1 line	0 comments	Download
M	Source/modules/mediastream/RTCPeerConnection.cpp	View		6 chunks	+6 lines, -6 lines	0 comments	Download
M	Source/modules/mediastream/RTCSessionDescription.cpp	View		2 chunks	+2 lines, -2 lines	0 comments	Download

Total messages: 11 (0 generated)

haraken

What's the behavior of Firefox and IE? Do they throw TypeError?

6 years, 8 months ago (2014-04-11 12:59:14 UTC) #3

zino

On 2014/04/11 12:59:14, haraken wrote: > What's the behavior of Firefox and IE? Do they ...

6 years, 8 months ago (2014-04-11 15:18:32 UTC) #4

haraken

On 2014/04/11 15:18:32, zino wrote: > On 2014/04/11 12:59:14, haraken wrote: > > What's the ...

6 years, 8 months ago (2014-04-11 15:32:33 UTC) #5

zino

On 2014/04/11 15:32:33, haraken wrote: > On 2014/04/11 15:18:32, zino wrote: > > On 2014/04/11 ...

6 years, 8 months ago (2014-04-11 15:39:31 UTC) #6

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jinho.bang@samsung.com/235123002/20001

6 years, 8 months ago (2014-04-11 16:34:10 UTC) #8

commit-bot: I haz the power

The CQ bit was unchecked by commit-bot@chromium.org

6 years, 8 months ago (2014-04-11 17:04:00 UTC) #9

commit-bot: I haz the power

Try jobs failed on following builders: tryserver.blink on linux_blink_rel

6 years, 8 months ago (2014-04-11 17:04:00 UTC) #10

lgombos

5 years, 6 months ago (2015-06-03 19:00:27 UTC) #11

Jinho, what is the next stop with this CL ? Do you need to rebase this or does
this needs to be abandoned ?