Source/modules/mediastream/RTCDataChannel.cpp - Issue 235123002: Should throw TypeError instead of TypeMismatchError (modules)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/modules/mediastream/RTCDataChannel.cpp

Issue 235123002: Should throw TypeError instead of TypeMismatchError (modules) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/modules/mediastream/RTCDataChannel.cpp

diff --git a/Source/modules/mediastream/RTCDataChannel.cpp b/Source/modules/mediastream/RTCDataChannel.cpp

index 43e24e8ff655fb5f953b15db69d7cea026a0f45d..4d5fedb3401de91bac329e14639c826b62327241 100644

--- a/Source/modules/mediastream/RTCDataChannel.cpp

+++ b/Source/modules/mediastream/RTCDataChannel.cpp

@@ -165,7 +165,7 @@ void RTCDataChannel::setBinaryType(const String& binaryType, ExceptionState& exc

else if (binaryType == "arraybuffer")

m_binaryType = BinaryTypeArrayBuffer;

else

- exceptionState.throwDOMException(TypeMismatchError, "Unknown binary type : " + binaryType);

+ exceptionState.throwDOMException(TypeError, "Unknown binary type : " + binaryType);

}

void RTCDataChannel::send(const String& data, ExceptionState& exceptionState)

« no previous file with comments | « Source/modules/mediastream/MediaStream.cpp ('k') | Source/modules/mediastream/RTCIceCandidate.cpp » ('j') | no next file with comments »