Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1569)

Unified Diff: Source/modules/mediastream/RTCSessionDescription.cpp

Issue 235123002: Should throw TypeError instead of TypeMismatchError (modules) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/modules/mediastream/RTCPeerConnection.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/modules/mediastream/RTCSessionDescription.cpp
diff --git a/Source/modules/mediastream/RTCSessionDescription.cpp b/Source/modules/mediastream/RTCSessionDescription.cpp
index 33dad9a09598781558a95acf30884c98e07c7570..4e3f45ff4f413649c532d01960ac9bad6f02bb79 100644
--- a/Source/modules/mediastream/RTCSessionDescription.cpp
+++ b/Source/modules/mediastream/RTCSessionDescription.cpp
@@ -53,7 +53,7 @@ PassRefPtr<RTCSessionDescription> RTCSessionDescription::create(const Dictionary
String type;
bool ok = descriptionInitDict.get("type", type);
if (ok && !verifyType(type)) {
- exceptionState.throwDOMException(TypeMismatchError, constructIllegalTypeExceptionMessage(type));
+ exceptionState.throwDOMException(TypeError, constructIllegalTypeExceptionMessage(type));
return nullptr;
}
@@ -84,7 +84,7 @@ void RTCSessionDescription::setType(const String& type, ExceptionState& exceptio
if (verifyType(type))
m_webSessionDescription.setType(type);
else
- exceptionState.throwDOMException(TypeMismatchError, constructIllegalTypeExceptionMessage(type));
+ exceptionState.throwDOMException(TypeError, constructIllegalTypeExceptionMessage(type));
}
String RTCSessionDescription::sdp()
« no previous file with comments | « Source/modules/mediastream/RTCPeerConnection.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698