Source/modules/crypto/Crypto.cpp - Issue 235123002: Should throw TypeError instead of TypeMismatchError (modules)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/modules/crypto/Crypto.cpp

Issue 235123002: Should throw TypeError instead of TypeMismatchError (modules) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/fast/mediastream/RTCSessionDescription-expected.txt ('k') | Source/modules/encryptedmedia/HTMLMediaElementEncryptedMedia.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/modules/crypto/Crypto.cpp

diff --git a/Source/modules/crypto/Crypto.cpp b/Source/modules/crypto/Crypto.cpp

index a5d40861a0ace80ebdb4a9703513b7b43c3f19da..d54a14a04b0ff150a0d17d9edf7341b9720be1bf 100644

--- a/Source/modules/crypto/Crypto.cpp

+++ b/Source/modules/crypto/Crypto.cpp

@@ -61,11 +61,11 @@ Crypto::Crypto()

void Crypto::getRandomValues(ArrayBufferView* array, ExceptionState& exceptionState)

{

if (!array) {

- exceptionState.throwDOMException(TypeMismatchError, "The provided ArrayBufferView is null.");

+ exceptionState.throwDOMException(TypeError, "The provided ArrayBufferView is null.");

return;

}

if (!isIntegerArray(array)) {

- exceptionState.throwDOMException(TypeMismatchError, String::format("The provided ArrayBufferView is of type '%s', which is not an integer array type.", array->typeName()));

+ exceptionState.throwDOMException(TypeError, String::format("The provided ArrayBufferView is of type '%s', which is not an integer array type.", array->typeName()));

return;

}

if (array->byteLength() > 65536) {