Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1929)

Unified Diff: Source/modules/mediastream/RTCIceCandidate.cpp

Issue 235123002: Should throw TypeError instead of TypeMismatchError (modules) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/modules/mediastream/RTCDataChannel.cpp ('k') | Source/modules/mediastream/RTCPeerConnection.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/modules/mediastream/RTCIceCandidate.cpp
diff --git a/Source/modules/mediastream/RTCIceCandidate.cpp b/Source/modules/mediastream/RTCIceCandidate.cpp
index 751ffea80a5501fffefb9a3e6b3d033f71c830f0..22b99bc720a2ca20252e78fb87b37b21367efcfc 100644
--- a/Source/modules/mediastream/RTCIceCandidate.cpp
+++ b/Source/modules/mediastream/RTCIceCandidate.cpp
@@ -44,7 +44,7 @@ PassRefPtr<RTCIceCandidate> RTCIceCandidate::create(const Dictionary& dictionary
String candidate;
bool ok = dictionary.get("candidate", candidate);
if (!ok || !candidate.length()) {
- exceptionState.throwDOMException(TypeMismatchError, ExceptionMessages::incorrectPropertyType("candidate", "is not a string, or is empty."));
+ exceptionState.throwDOMException(TypeError, ExceptionMessages::incorrectPropertyType("candidate", "is not a string, or is empty."));
return nullptr;
}
« no previous file with comments | « Source/modules/mediastream/RTCDataChannel.cpp ('k') | Source/modules/mediastream/RTCPeerConnection.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698