Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(711)

Side by Side Diff: Source/modules/crypto/Crypto.cpp

Issue 235123002: Should throw TypeError instead of TypeMismatchError (modules) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2011 Google Inc. All rights reserved. 2 * Copyright (C) 2011 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 7 *
8 * 1. Redistributions of source code must retain the above copyright 8 * 1. Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * 2. Redistributions in binary form must reproduce the above copyright 10 * 2. Redistributions in binary form must reproduce the above copyright
(...skipping 43 matching lines...) Expand 10 before | Expand all | Expand 10 after
54 } 54 }
55 55
56 Crypto::Crypto() 56 Crypto::Crypto()
57 { 57 {
58 ScriptWrappable::init(this); 58 ScriptWrappable::init(this);
59 } 59 }
60 60
61 void Crypto::getRandomValues(ArrayBufferView* array, ExceptionState& exceptionSt ate) 61 void Crypto::getRandomValues(ArrayBufferView* array, ExceptionState& exceptionSt ate)
62 { 62 {
63 if (!array) { 63 if (!array) {
64 exceptionState.throwDOMException(TypeMismatchError, "The provided ArrayB ufferView is null."); 64 exceptionState.throwDOMException(TypeError, "The provided ArrayBufferVie w is null.");
65 return; 65 return;
66 } 66 }
67 if (!isIntegerArray(array)) { 67 if (!isIntegerArray(array)) {
68 exceptionState.throwDOMException(TypeMismatchError, String::format("The provided ArrayBufferView is of type '%s', which is not an integer array type.", array->typeName())); 68 exceptionState.throwDOMException(TypeError, String::format("The provided ArrayBufferView is of type '%s', which is not an integer array type.", array->t ypeName()));
69 return; 69 return;
70 } 70 }
71 if (array->byteLength() > 65536) { 71 if (array->byteLength() > 65536) {
72 exceptionState.throwDOMException(QuotaExceededError, String::format("The ArrayBufferView's byte length (%u) exceeds the number of bytes of entropy avail able via this API (65536).", array->byteLength())); 72 exceptionState.throwDOMException(QuotaExceededError, String::format("The ArrayBufferView's byte length (%u) exceeds the number of bytes of entropy avail able via this API (65536).", array->byteLength()));
73 return; 73 return;
74 } 74 }
75 cryptographicallyRandomValues(array->baseAddress(), array->byteLength()); 75 cryptographicallyRandomValues(array->baseAddress(), array->byteLength());
76 } 76 }
77 77
78 SubtleCrypto* Crypto::subtle() 78 SubtleCrypto* Crypto::subtle()
79 { 79 {
80 if (!m_subtleCrypto) 80 if (!m_subtleCrypto)
81 m_subtleCrypto = SubtleCrypto::create(); 81 m_subtleCrypto = SubtleCrypto::create();
82 return m_subtleCrypto.get(); 82 return m_subtleCrypto.get();
83 } 83 }
84 84
85 void Crypto::trace(Visitor* visitor) 85 void Crypto::trace(Visitor* visitor)
86 { 86 {
87 visitor->trace(m_subtleCrypto); 87 visitor->trace(m_subtleCrypto);
88 } 88 }
89 89
90 } 90 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698