Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(578)

Side by Side Diff: Source/modules/mediastream/RTCSessionDescription.cpp

Issue 235123002: Should throw TypeError instead of TypeMismatchError (modules) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/modules/mediastream/RTCPeerConnection.cpp ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2012 Google Inc. All rights reserved. 2 * Copyright (C) 2012 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 7 *
8 * 1. Redistributions of source code must retain the above copyright 8 * 1. Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * 2. Redistributions in binary form must reproduce the above copyright 10 * 2. Redistributions in binary form must reproduce the above copyright
(...skipping 35 matching lines...) Expand 10 before | Expand all | Expand 10 after
46 static String constructIllegalTypeExceptionMessage(const String& type) 46 static String constructIllegalTypeExceptionMessage(const String& type)
47 { 47 {
48 return "Illegal value of attribute 'type' : " + type; 48 return "Illegal value of attribute 'type' : " + type;
49 } 49 }
50 50
51 PassRefPtr<RTCSessionDescription> RTCSessionDescription::create(const Dictionary & descriptionInitDict, ExceptionState& exceptionState) 51 PassRefPtr<RTCSessionDescription> RTCSessionDescription::create(const Dictionary & descriptionInitDict, ExceptionState& exceptionState)
52 { 52 {
53 String type; 53 String type;
54 bool ok = descriptionInitDict.get("type", type); 54 bool ok = descriptionInitDict.get("type", type);
55 if (ok && !verifyType(type)) { 55 if (ok && !verifyType(type)) {
56 exceptionState.throwDOMException(TypeMismatchError, constructIllegalType ExceptionMessage(type)); 56 exceptionState.throwDOMException(TypeError, constructIllegalTypeExceptio nMessage(type));
57 return nullptr; 57 return nullptr;
58 } 58 }
59 59
60 String sdp; 60 String sdp;
61 descriptionInitDict.get("sdp", sdp); 61 descriptionInitDict.get("sdp", sdp);
62 62
63 return adoptRef(new RTCSessionDescription(blink::WebRTCSessionDescription(ty pe, sdp))); 63 return adoptRef(new RTCSessionDescription(blink::WebRTCSessionDescription(ty pe, sdp)));
64 } 64 }
65 65
66 PassRefPtr<RTCSessionDescription> RTCSessionDescription::create(blink::WebRTCSes sionDescription webSessionDescription) 66 PassRefPtr<RTCSessionDescription> RTCSessionDescription::create(blink::WebRTCSes sionDescription webSessionDescription)
(...skipping 10 matching lines...) Expand all
77 String RTCSessionDescription::type() 77 String RTCSessionDescription::type()
78 { 78 {
79 return m_webSessionDescription.type(); 79 return m_webSessionDescription.type();
80 } 80 }
81 81
82 void RTCSessionDescription::setType(const String& type, ExceptionState& exceptio nState) 82 void RTCSessionDescription::setType(const String& type, ExceptionState& exceptio nState)
83 { 83 {
84 if (verifyType(type)) 84 if (verifyType(type))
85 m_webSessionDescription.setType(type); 85 m_webSessionDescription.setType(type);
86 else 86 else
87 exceptionState.throwDOMException(TypeMismatchError, constructIllegalType ExceptionMessage(type)); 87 exceptionState.throwDOMException(TypeError, constructIllegalTypeExceptio nMessage(type));
88 } 88 }
89 89
90 String RTCSessionDescription::sdp() 90 String RTCSessionDescription::sdp()
91 { 91 {
92 return m_webSessionDescription.sdp(); 92 return m_webSessionDescription.sdp();
93 } 93 }
94 94
95 void RTCSessionDescription::setSdp(const String& sdp) 95 void RTCSessionDescription::setSdp(const String& sdp)
96 { 96 {
97 m_webSessionDescription.setSDP(sdp); 97 m_webSessionDescription.setSDP(sdp);
98 } 98 }
99 99
100 blink::WebRTCSessionDescription RTCSessionDescription::webSessionDescription() 100 blink::WebRTCSessionDescription RTCSessionDescription::webSessionDescription()
101 { 101 {
102 return m_webSessionDescription; 102 return m_webSessionDescription;
103 } 103 }
104 104
105 } // namespace WebCore 105 } // namespace WebCore
OLDNEW
« no previous file with comments | « Source/modules/mediastream/RTCPeerConnection.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698