Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(124)

Issue 23464082: Revert "Add a requiresVertexShader method to GrGLEffect" (Closed)

Created:
7 years, 3 months ago by Chris Dalton
Modified:
7 years, 2 months ago
Reviewers:
bsalomon
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

Revert "Add a requiresVertexShader method to GrGLEffect" This reverts commit 1a30a3af805b7ea688d4a0f0bfe373c204085a27. We're going to take a different direction for vertexless shaders. Committed: http://code.google.com/p/skia/source/detail?r=11521

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+64 lines, -124 lines) Patch
M src/gpu/GrAAConvexPathRenderer.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M src/gpu/GrAARectRenderer.cpp View 2 chunks +0 lines, -4 lines 0 comments Download
M src/gpu/GrOvalRenderer.cpp View 2 chunks +0 lines, -4 lines 0 comments Download
M src/gpu/effects/GrBezierEffect.cpp View 3 chunks +0 lines, -6 lines 0 comments Download
M src/gpu/effects/GrSimpleTextureEffect.cpp View 1 chunk +0 lines, -5 lines 0 comments Download
M src/gpu/gl/GrGLEffect.h View 1 chunk +0 lines, -7 lines 0 comments Download
M src/gpu/gl/GrGLEffectMatrix.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M src/gpu/gl/GrGLProgram.h View 1 chunk +0 lines, -8 lines 0 comments Download
M src/gpu/gl/GrGLProgram.cpp View 5 chunks +25 lines, -54 lines 0 comments Download
M src/gpu/gl/GrGLShaderBuilder.h View 4 chunks +20 lines, -20 lines 0 comments Download
M src/gpu/gl/GrGLShaderBuilder.cpp View 7 chunks +19 lines, -13 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Chris Dalton
We probably don't want to take this until the entire vertexless rework is ready to ...
7 years, 3 months ago (2013-09-18 20:17:48 UTC) #1
bsalomon
lgtm
7 years, 3 months ago (2013-09-18 20:18:05 UTC) #2
bsalomon
On 2013/09/18 20:18:05, bsalomon wrote: > lgtm Do you want me to commit this?
7 years, 3 months ago (2013-09-18 20:18:16 UTC) #3
bsalomon
On 2013/09/18 20:17:48, cdalton wrote: > We probably don't want to take this until the ...
7 years, 3 months ago (2013-09-18 21:16:56 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/cdalton@nvidia.com/23464082/1
7 years, 2 months ago (2013-09-30 15:03:15 UTC) #5
commit-bot: I haz the power
7 years, 2 months ago (2013-09-30 15:14:07 UTC) #6
Message was sent while issue was closed.
Change committed as 11521

Powered by Google App Engine
This is Rietveld 408576698