Replace ASSERT*() with DCHECK*() in core/fetch/ and core/loader/

Replace ASSERT*() with DCHECK*() in core/fetch/ and core/loader/

sed -i 's/ ASSERT(/ DCHECK(/g'
sed -i 's/ RELEASE_ASSERT(/ CHECK(/g'
sed -i 's/ ASSERT_NOT_REACHED(/ NOTREACHED(/g'
sed -i 's/ ASSERT_WITH_SECURITY_IMPLICATION(/ SECURITY_DCHECK(/g'
perl -npe '$_ =~ s/ASSERT_UNUSED\((.*?), (.*)\);$/DCHECK($2);/g'

for `find third_party/WebKit/Source/core/{fetch,loader}/ -name '*.*'`.

This CL replaces
- DCHECK(a == b) with DCHECK_EQ(a, b)
- DCHECK(a && b) with DCHECK(a) and DCHECK(b)
etc. manually.

BUG=645395, 596760
Committed: https://crrev.com/b4c242bce2dd77f07a5d2b051088688f1ebbab86
Cr-Commit-Position: refs/heads/master@{#418606}

[hiroshige, 2016-09-09 09:06:13]

Description was changed from

==========
Replace ASSERT() with DCHECK() (also similar ones)

sed -i 's/ ASSERT(/ DCHECK(/g'
sed -i 's/ RELEASE_ASSERT(/ CHECK(/g'
sed -i 's/ ASSERT_NOT_REACHED(/ NOTREACHED(/g'
sed -i 's/ ASSERT_WITH_SECURITY_IMPLICATION(/ SECURITY_DCHECK(/g'

for `find third_party/WebKit/Source/core/{fetch,loader}/ -name '*.*'`.

This CL replaces DCHECK(a == b) with DCHECK_EQ(a, b) etc. manually.

BUG=645395
==========

to

==========
Replace ASSERT() with DCHECK() (also similar ones)

sed -i 's/ ASSERT(/ DCHECK(/g'
sed -i 's/ RELEASE_ASSERT(/ CHECK(/g'
sed -i 's/ ASSERT_NOT_REACHED(/ NOTREACHED(/g'
sed -i 's/ ASSERT_WITH_SECURITY_IMPLICATION(/ SECURITY_DCHECK(/g'
perl -npe '$_ =~ s/^(\s+)ASSERT_UNUSED\((.*?),
(.*)\);$/$1ALLOW_UNUSED_LOCAL($2);\n$1DCHECK($3);/g'

for `find third_party/WebKit/Source/core/{fetch,loader}/ -name '*.*'`.

This CL replaces DCHECK(a == b) with DCHECK_EQ(a, b) etc. manually.

BUG=645395
==========

[hiroshige, 2016-09-09 09:08:52]

hiroshige@chromium.org changed reviewers:
+ yhirano@chromium.org

[hiroshige, 2016-09-09 09:08:53]

PTAL.

[hiroshige, 2016-09-09 09:20:29]

Description was changed from

==========
Replace ASSERT() with DCHECK() (also similar ones)

sed -i 's/ ASSERT(/ DCHECK(/g'
sed -i 's/ RELEASE_ASSERT(/ CHECK(/g'
sed -i 's/ ASSERT_NOT_REACHED(/ NOTREACHED(/g'
sed -i 's/ ASSERT_WITH_SECURITY_IMPLICATION(/ SECURITY_DCHECK(/g'
perl -npe '$_ =~ s/^(\s+)ASSERT_UNUSED\((.*?),
(.*)\);$/$1ALLOW_UNUSED_LOCAL($2);\n$1DCHECK($3);/g'

for `find third_party/WebKit/Source/core/{fetch,loader}/ -name '*.*'`.

This CL replaces DCHECK(a == b) with DCHECK_EQ(a, b) etc. manually.

BUG=645395
==========

to

==========
Replace ASSERT() with DCHECK() etc. core/fetch, loader

sed -i 's/ ASSERT(/ DCHECK(/g'
sed -i 's/ RELEASE_ASSERT(/ CHECK(/g'
sed -i 's/ ASSERT_NOT_REACHED(/ NOTREACHED(/g'
sed -i 's/ ASSERT_WITH_SECURITY_IMPLICATION(/ SECURITY_DCHECK(/g'
perl -npe '$_ =~ s/^(\s+)ASSERT_UNUSED\((.*?),
(.*)\);$/$1ALLOW_UNUSED_LOCAL($2);\n$1DCHECK($3);/g'

for `find third_party/WebKit/Source/core/{fetch,loader}/ -name '*.*'`.

This CL replaces DCHECK(a == b) with DCHECK_EQ(a, b) etc. manually.

BUG=645395
==========

[hiroshige, 2016-09-09 09:31:16]

Description was changed from

==========
Replace ASSERT() with DCHECK() etc. core/fetch, loader

sed -i 's/ ASSERT(/ DCHECK(/g'
sed -i 's/ RELEASE_ASSERT(/ CHECK(/g'
sed -i 's/ ASSERT_NOT_REACHED(/ NOTREACHED(/g'
sed -i 's/ ASSERT_WITH_SECURITY_IMPLICATION(/ SECURITY_DCHECK(/g'
perl -npe '$_ =~ s/^(\s+)ASSERT_UNUSED\((.*?),
(.*)\);$/$1ALLOW_UNUSED_LOCAL($2);\n$1DCHECK($3);/g'

for `find third_party/WebKit/Source/core/{fetch,loader}/ -name '*.*'`.

This CL replaces DCHECK(a == b) with DCHECK_EQ(a, b) etc. manually.

BUG=645395
==========

to

==========
Replace ASSERT*() with DCHECK*() in core/fetch/ and core/loader/

sed -i 's/ ASSERT(/ DCHECK(/g'
sed -i 's/ RELEASE_ASSERT(/ CHECK(/g'
sed -i 's/ ASSERT_NOT_REACHED(/ NOTREACHED(/g'
sed -i 's/ ASSERT_WITH_SECURITY_IMPLICATION(/ SECURITY_DCHECK(/g'
perl -npe '$_ =~ s/^(\s+)ASSERT_UNUSED\((.*?),
(.*)\);$/$1ALLOW_UNUSED_LOCAL($2);\n$1DCHECK($3);/g'

for `find third_party/WebKit/Source/core/{fetch,loader}/ -name '*.*'`.

This CL replaces DCHECK(a == b) with DCHECK_EQ(a, b) etc. manually.

BUG=645395
==========

[hiroshige, 2016-09-09 09:31:29]

Description was changed from

==========
Replace ASSERT*() with DCHECK*() in core/fetch/ and core/loader/

sed -i 's/ ASSERT(/ DCHECK(/g'
sed -i 's/ RELEASE_ASSERT(/ CHECK(/g'
sed -i 's/ ASSERT_NOT_REACHED(/ NOTREACHED(/g'
sed -i 's/ ASSERT_WITH_SECURITY_IMPLICATION(/ SECURITY_DCHECK(/g'
perl -npe '$_ =~ s/^(\s+)ASSERT_UNUSED\((.*?),
(.*)\);$/$1ALLOW_UNUSED_LOCAL($2);\n$1DCHECK($3);/g'

for `find third_party/WebKit/Source/core/{fetch,loader}/ -name '*.*'`.

This CL replaces DCHECK(a == b) with DCHECK_EQ(a, b) etc. manually.

BUG=645395
==========

to

==========
Replace ASSERT*() with DCHECK*() in core/fetch/ and core/loader/

sed -i 's/ ASSERT(/ DCHECK(/g'
sed -i 's/ RELEASE_ASSERT(/ CHECK(/g'
sed -i 's/ ASSERT_NOT_REACHED(/ NOTREACHED(/g'
sed -i 's/ ASSERT_WITH_SECURITY_IMPLICATION(/ SECURITY_DCHECK(/g'
perl -npe '$_ =~ s/^(\s+)ASSERT_UNUSED\((.*?),
(.*)\);$/$1ALLOW_UNUSED_LOCAL($2);\n$1DCHECK($3);/g'

for `find third_party/WebKit/Source/core/{fetch,loader}/ -name '*.*'`.

This CL replaces DCHECK(a == b) with DCHECK_EQ(a, b) etc. manually.

BUG=645395, 596760
==========

[yhirano, 2016-09-12 04:33:14]

https://codereview.chromium.org/2327643003/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/fetch/LinkFetchResource.cpp (right):

https://codereview.chromium.org/2327643003/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/fetch/LinkFetchResource.cpp:15: DCHECK(type ==
LinkPrefetch);
DCHECK_EQ

https://codereview.chromium.org/2327643003/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/fetch/LinkFetchResource.cpp:16:
DCHECK(request.resourceRequest().frameType() == WebURLRequest::FrameTypeNone);
ditto

https://codereview.chromium.org/2327643003/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/fetch/MemoryCache.cpp (right):

https://codereview.chromium.org/2327643003/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/fetch/MemoryCache.cpp:358: DCHECK(minDeadBytes <=
maxDeadBytes);
DCHECK_LE

https://codereview.chromium.org/2327643003/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/fetch/MemoryCache.cpp:359: DCHECK(maxDeadBytes <=
totalBytes);
ditto

https://codereview.chromium.org/2327643003/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/fetch/MemoryCache.cpp:384: DCHECK(it !=
resources->end());
DCHECK_NE

https://codereview.chromium.org/2327643003/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/fetch/MemoryCache.cpp:515:
DCHECK(!entry->m_nextInLiveResourcesList &&
!entry->m_previousInLiveResourcesList && !entry->m_inLiveDecodedResourcesList);
It would be good to have three separate DCHECKs.

https://codereview.chromium.org/2327643003/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/fetch/MemoryCache.cpp:523: DCHECK(m_deadSize >=
resource->size());
DCHEK_GE

https://codereview.chromium.org/2327643003/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/fetch/Resource.cpp (right):

https://codereview.chromium.org/2327643003/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/fetch/Resource.cpp:309: DCHECK(m_type ==
unsigned(type)); // m_type is a bitfield, so this tests careless updates of the
enum.
DCHECK_EQ

https://codereview.chromium.org/2327643003/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/fetch/Resource.cpp:385:
DCHECK(m_options.dataBufferingPolicy == BufferData);
DCHECK_EQ

https://codereview.chromium.org/2327643003/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/fetch/Resource.cpp:754:
ALLOW_UNUSED_LOCAL(timer);
Is this needed? DCHECK requires its expectation as well-formed even if
DCHECK_IS_ON is false, and that means the expression is evaluated by the
compiler, I guess?

https://codereview.chromium.org/2327643003/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/fetch/Resource.cpp:755: DCHECK(timer ==
&m_cancelTimer);
DCHECK_EQ

https://codereview.chromium.org/2327643003/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/fetch/ResourceFetcher.cpp (right):

https://codereview.chromium.org/2327643003/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/fetch/ResourceFetcher.cpp:524:
ALLOW_UNUSED_LOCAL(timer);
ditto as Resource::cancelTimerFired

https://codereview.chromium.org/2327643003/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/fetch/ResourceFetcher.cpp:525: DCHECK(timer ==
&m_resourceTimingReportTimer);
DCHECK_EQ

https://codereview.chromium.org/2327643003/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/fetch/ResourceFetcher.cpp:567:
DCHECK(context().getCachePolicy() != CachePolicyReload);
DCHECK_NE

https://codereview.chromium.org/2327643003/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/fetch/ScriptResource.cpp (right):

https://codereview.chromium.org/2327643003/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/fetch/ScriptResource.cpp:112: DCHECK(disposition
!= ScriptIntegrityDisposition::NotChecked);
DCHECK_NE

https://codereview.chromium.org/2327643003/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/loader/DocumentLoadTiming.cpp (right):

https://codereview.chromium.org/2327643003/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/loader/DocumentLoadTiming.cpp:108:
DCHECK(!m_navigationStart && !m_referenceMonotonicTime && !m_referenceWallTime);
How about having three DCHECKs?

https://codereview.chromium.org/2327643003/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/loader/DocumentLoader.cpp (right):

https://codereview.chromium.org/2327643003/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/loader/DocumentLoader.cpp:240: DCHECK(m_state >=
Committed);
DCHECK_GE

https://codereview.chromium.org/2327643003/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/loader/DocumentLoader.cpp:275:
ALLOW_UNUSED_LOCAL(resource);
ditto as Resource::cancelTimerFired.

https://codereview.chromium.org/2327643003/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/loader/DocumentLoader.cpp:276:
DCHECK(m_mainResource == resource);
DCHECK_EQ

https://codereview.chromium.org/2327643003/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/loader/DocumentLoader.cpp:327:
ALLOW_UNUSED_LOCAL(resource);
ditto as Resource::cancelTimerFired.

https://codereview.chromium.org/2327643003/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/loader/DocumentLoader.cpp:328: DCHECK(resource ==
m_mainResource);
DCHECK_EQ

https://codereview.chromium.org/2327643003/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/loader/DocumentLoader.cpp:408:
ALLOW_UNUSED_LOCAL(resource);
ditto as Resource::cancelTimerFired.

https://codereview.chromium.org/2327643003/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/loader/DocumentLoader.cpp:409:
DCHECK(m_mainResource == resource);
DCHECK_EQ

https://codereview.chromium.org/2327643003/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/loader/DocumentLoader.cpp:410:
ALLOW_UNUSED_LOCAL(handle);
ditto as Resource::cancelTimerFired.

https://codereview.chromium.org/2327643003/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/loader/DocumentLoader.cpp:501: DCHECK(m_state <
MainResourceDone);
DCHECK_LT

https://codereview.chromium.org/2327643003/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/loader/DocumentLoader.cpp:519:
ALLOW_UNUSED_LOCAL(resource);
ditto as Resource::cancelTimerFired.

https://codereview.chromium.org/2327643003/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/loader/DocumentLoader.cpp:520: DCHECK(resource ==
m_mainResource);
DCHECK_EQ

https://codereview.chromium.org/2327643003/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/loader/DocumentLoader.cpp:662: DCHECK(m_state ==
NotStarted);
DCHECK_EQ

https://codereview.chromium.org/2327643003/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/loader/DocumentLoader.cpp:694:
ALLOW_UNUSED_LOCAL(writer);
ditto as Resource::cancelTimerFired.

https://codereview.chromium.org/2327643003/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/loader/DocumentLoader.cpp:695: DCHECK(m_writer ==
writer);
DCHECK_EQ

https://codereview.chromium.org/2327643003/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/loader/DocumentThreadableLoader.cpp (right):

https://codereview.chromium.org/2327643003/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/loader/DocumentThreadableLoader.cpp:421:
ALLOW_UNUSED_LOCAL(resource);
ditto as Resource::cancelTimerFired.

https://codereview.chromium.org/2327643003/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/loader/DocumentThreadableLoader.cpp:422:
DCHECK(resource == this->resource());
DCHECK_EQ

https://codereview.chromium.org/2327643003/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/loader/DocumentThreadableLoader.cpp:572:
ALLOW_UNUSED_LOCAL(resource);
ditto as Resource::cancelTimerFired.

https://codereview.chromium.org/2327643003/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/loader/DocumentThreadableLoader.cpp:573:
DCHECK(resource == this->resource());
DCHECK_EQ

https://codereview.chromium.org/2327643003/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/loader/DocumentThreadableLoader.cpp:583:
ALLOW_UNUSED_LOCAL(resource);
ditto as Resource::cancelTimerFired.

https://codereview.chromium.org/2327643003/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/loader/DocumentThreadableLoader.cpp:584:
DCHECK(resource == this->resource());
DCHECK_EQ

https://codereview.chromium.org/2327643003/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/loader/DocumentThreadableLoader.cpp:595:
ALLOW_UNUSED_LOCAL(resource);
ditto as Resource::cancelTimerFired.

https://codereview.chromium.org/2327643003/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/loader/DocumentThreadableLoader.cpp:596:
DCHECK(resource == this->resource());
DCHECK_EQ

https://codereview.chromium.org/2327643003/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/loader/DocumentThreadableLoader.cpp:604:
ALLOW_UNUSED_LOCAL(resource);
ditto as Resource::cancelTimerFired.

https://codereview.chromium.org/2327643003/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/loader/DocumentThreadableLoader.cpp:605:
DCHECK(resource == this->resource());
DCHECK_EQ

https://codereview.chromium.org/2327643003/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/loader/DocumentThreadableLoader.cpp:726:
ALLOW_UNUSED_LOCAL(resource);
ditto as Resource::cancelTimerFired.

https://codereview.chromium.org/2327643003/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/loader/DocumentThreadableLoader.cpp:727:
DCHECK(resource == this->resource());
DCHECK_EQ

https://codereview.chromium.org/2327643003/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/loader/DocumentThreadableLoader.cpp:756:
DCHECK(resource == this->resource());
DCHECK_EQ

https://codereview.chromium.org/2327643003/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/loader/DocumentThreadableLoader.cpp:777:
DCHECK(m_options.crossOriginRequestPolicy == UseAccessControl);
DCHECK_EQ

https://codereview.chromium.org/2327643003/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/loader/DocumentThreadableLoader.cpp:792:
ALLOW_UNUSED_LOCAL(timer);
ditto as Resource::cancelTimerFired.

https://codereview.chromium.org/2327643003/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/loader/DocumentThreadableLoader.cpp:793:
DCHECK(timer == &m_timeoutTimer);
DCHECK_EQ

https://codereview.chromium.org/2327643003/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/loader/FrameLoader.cpp (right):

https://codereview.chromium.org/2327643003/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/loader/FrameLoader.cpp:1129:
DCHECK(m_provisionalDocumentLoader == pdl);
DCHECK_EQ

https://codereview.chromium.org/2327643003/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/loader/FrameLoader.cpp:1282: DCHECK(loader ==
m_documentLoader);
DCHECK_EQ

https://codereview.chromium.org/2327643003/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/loader/FrameLoaderStateMachine.cpp (right):

https://codereview.chromium.org/2327643003/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/loader/FrameLoaderStateMachine.cpp:64:
DCHECK(m_state < state);
DCHECK_LT

https://codereview.chromium.org/2327643003/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/loader/HttpEquiv.cpp (right):

https://codereview.chromium.org/2327643003/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/loader/HttpEquiv.cpp:24: DCHECK(!equiv.isNull()
&& !content.isNull());
How about having two DCHECKs?

https://codereview.chromium.org/2327643003/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/loader/ImageLoader.cpp (right):

https://codereview.chromium.org/2327643003/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/loader/ImageLoader.cpp:441: DCHECK(resource ==
m_image.get());
DCHECK_EQ

https://codereview.chromium.org/2327643003/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/loader/LinkLoader.cpp (right):

https://codereview.chromium.org/2327643003/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/loader/LinkLoader.cpp:87:
ALLOW_UNUSED_LOCAL(timer);
ditto as Resource::cancelTimerFired.

https://codereview.chromium.org/2327643003/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/loader/LinkLoader.cpp:88: DCHECK(timer ==
&m_linkLoadTimer);
DCHECK_EQ

https://codereview.chromium.org/2327643003/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/loader/LinkLoader.cpp:94:
ALLOW_UNUSED_LOCAL(timer);
ditto as Resource::cancelTimerFired.

https://codereview.chromium.org/2327643003/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/loader/LinkLoader.cpp:95: DCHECK(timer ==
&m_linkLoadingErrorTimer);
DCHECK_EQ

https://codereview.chromium.org/2327643003/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/loader/LinkLoader.cpp:109:
DCHECK(this->resource() == resource);
DCHECK_EQ

https://codereview.chromium.org/2327643003/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/loader/LinkLoader.cpp:178: DCHECK(as.lower() ==
as);
DCHECK_EQ

https://codereview.chromium.org/2327643003/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/loader/LinkPreloadResourceClients.h (right):

https://codereview.chromium.org/2327643003/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/loader/LinkPreloadResourceClients.h:59:
DCHECK(this->resource() == resource);
DCHECK_EQ

https://codereview.chromium.org/2327643003/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/loader/LinkPreloadResourceClients.h:92:
DCHECK(this->resource() == resource);
DCHECK_EQ

https://codereview.chromium.org/2327643003/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/loader/LinkPreloadResourceClients.h:125:
DCHECK(this->resource() == toImageResource(resource));
DCHECK_EQ

https://codereview.chromium.org/2327643003/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/loader/LinkPreloadResourceClients.h:158:
DCHECK(this->resource() == toFontResource(resource));
DCHECK_EQ

https://codereview.chromium.org/2327643003/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/loader/LinkPreloadResourceClients.h:191:
DCHECK(this->resource() == toRawResource(resource));
DCHECK_EQ

https://codereview.chromium.org/2327643003/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/loader/TextTrackLoader.cpp (right):

https://codereview.chromium.org/2327643003/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/loader/TextTrackLoader.cpp:54:
ALLOW_UNUSED_LOCAL(timer);
ditto as Resource::cancelTimerFired.

https://codereview.chromium.org/2327643003/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/loader/TextTrackLoader.cpp:55: DCHECK(timer ==
&m_cueLoadTimer);
DCHECK_EQ

https://codereview.chromium.org/2327643003/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/loader/TextTrackLoader.cpp:73:
DCHECK(this->resource() == resource);
DCHECK_EQ

https://codereview.chromium.org/2327643003/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/loader/TextTrackLoader.cpp:93:
DCHECK(this->resource() == resource);
DCHECK_EQ

[hiroshige, 2016-09-13 08:43:17]

hiroshige@chromium.org changed reviewers:
+ tkent@chromium.org

[hiroshige, 2016-09-13 08:43:21]

+tkent@, could you take a look at the usage of ALLOW_UNUSED_LOCAL()?
https://codereview.chromium.org/2327643003/diff/40001/third_party/WebKit/Sour...

https://codereview.chromium.org/2327643003/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/fetch/LinkFetchResource.cpp (right):

https://codereview.chromium.org/2327643003/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/fetch/LinkFetchResource.cpp:15: DCHECK(type ==
LinkPrefetch);
On 2016/09/12 04:33:11, yhirano (slow) wrote:
> DCHECK_EQ

Done.

https://codereview.chromium.org/2327643003/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/fetch/LinkFetchResource.cpp:16:
DCHECK(request.resourceRequest().frameType() == WebURLRequest::FrameTypeNone);
On 2016/09/12 04:33:11, yhirano (slow) wrote:
> ditto

Done.

https://codereview.chromium.org/2327643003/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/fetch/MemoryCache.cpp (right):

https://codereview.chromium.org/2327643003/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/fetch/MemoryCache.cpp:358: DCHECK(minDeadBytes <=
maxDeadBytes);
On 2016/09/12 04:33:11, yhirano (slow) wrote:
> DCHECK_LE

Done.

https://codereview.chromium.org/2327643003/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/fetch/MemoryCache.cpp:359: DCHECK(maxDeadBytes <=
totalBytes);
On 2016/09/12 04:33:11, yhirano (slow) wrote:
> ditto

Done.

https://codereview.chromium.org/2327643003/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/fetch/MemoryCache.cpp:384: DCHECK(it !=
resources->end());
On 2016/09/12 04:33:11, yhirano (slow) wrote:
> DCHECK_NE

Done.

https://codereview.chromium.org/2327643003/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/fetch/MemoryCache.cpp:515:
DCHECK(!entry->m_nextInLiveResourcesList &&
!entry->m_previousInLiveResourcesList && !entry->m_inLiveDecodedResourcesList);
On 2016/09/12 04:33:11, yhirano (slow) wrote:
> It would be good to have three separate DCHECKs.

Done.

https://codereview.chromium.org/2327643003/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/fetch/MemoryCache.cpp:523: DCHECK(m_deadSize >=
resource->size());
On 2016/09/12 04:33:11, yhirano (slow) wrote:
> DCHEK_GE

Done.

https://codereview.chromium.org/2327643003/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/fetch/Resource.cpp (right):

https://codereview.chromium.org/2327643003/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/fetch/Resource.cpp:309: DCHECK(m_type ==
unsigned(type)); // m_type is a bitfield, so this tests careless updates of the
enum.
On 2016/09/12 04:33:12, yhirano (slow) wrote:
> DCHECK_EQ

Done.

https://codereview.chromium.org/2327643003/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/fetch/Resource.cpp:385:
DCHECK(m_options.dataBufferingPolicy == BufferData);
On 2016/09/12 04:33:11, yhirano (slow) wrote:
> DCHECK_EQ

Done.

https://codereview.chromium.org/2327643003/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/fetch/Resource.cpp:754:
ALLOW_UNUSED_LOCAL(timer);
On 2016/09/12 04:33:12, yhirano (slow) wrote:
> Is this needed? DCHECK requires its expectation as well-formed even if
> DCHECK_IS_ON is false, and that means the expression is evaluated by the
> compiler, I guess?

I put ALLOW_UNUSED_LOCAL() based on a comment in Assertions.h:
https://codesearch.chromium.org/chromium/src/third_party/WebKit/Source/wtf/As...

I removed ALLOW_UNUSED_LOCAL()s in Patch Set 5 and 6, and they passed on bots.

tkent@, how do you think about yhirano@'s comment?
Do we have specific bots/builders where compilation fails without
ALLOW_UNUSED_LOCAL()?

https://codereview.chromium.org/2327643003/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/fetch/Resource.cpp:755: DCHECK(timer ==
&m_cancelTimer);
On 2016/09/12 04:33:12, yhirano (slow) wrote:
> DCHECK_EQ

Done.

https://codereview.chromium.org/2327643003/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/fetch/ResourceFetcher.cpp (right):

https://codereview.chromium.org/2327643003/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/fetch/ResourceFetcher.cpp:524:
ALLOW_UNUSED_LOCAL(timer);
On 2016/09/12 04:33:12, yhirano (slow) wrote:
> ditto as Resource::cancelTimerFired

Done.

https://codereview.chromium.org/2327643003/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/fetch/ResourceFetcher.cpp:525: DCHECK(timer ==
&m_resourceTimingReportTimer);
On 2016/09/12 04:33:12, yhirano (slow) wrote:
> DCHECK_EQ

Done.

https://codereview.chromium.org/2327643003/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/fetch/ResourceFetcher.cpp:567:
DCHECK(context().getCachePolicy() != CachePolicyReload);
On 2016/09/12 04:33:12, yhirano (slow) wrote:
> DCHECK_NE

Done.

https://codereview.chromium.org/2327643003/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/fetch/ScriptResource.cpp (right):

https://codereview.chromium.org/2327643003/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/fetch/ScriptResource.cpp:112: DCHECK(disposition
!= ScriptIntegrityDisposition::NotChecked);
On 2016/09/12 04:33:12, yhirano (slow) wrote:
> DCHECK_NE

Done.

https://codereview.chromium.org/2327643003/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/loader/DocumentLoadTiming.cpp (right):

https://codereview.chromium.org/2327643003/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/loader/DocumentLoadTiming.cpp:108:
DCHECK(!m_navigationStart && !m_referenceMonotonicTime && !m_referenceWallTime);
On 2016/09/12 04:33:12, yhirano (slow) wrote:
> How about having three DCHECKs?

Done.

https://codereview.chromium.org/2327643003/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/loader/DocumentLoader.cpp (right):

https://codereview.chromium.org/2327643003/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/loader/DocumentLoader.cpp:240: DCHECK(m_state >=
Committed);
On 2016/09/12 04:33:12, yhirano (slow) wrote:
> DCHECK_GE

Done.

https://codereview.chromium.org/2327643003/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/loader/DocumentLoader.cpp:275:
ALLOW_UNUSED_LOCAL(resource);
On 2016/09/12 04:33:12, yhirano (slow) wrote:
> ditto as Resource::cancelTimerFired.

Done.

https://codereview.chromium.org/2327643003/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/loader/DocumentLoader.cpp:276:
DCHECK(m_mainResource == resource);
On 2016/09/12 04:33:12, yhirano (slow) wrote:
> DCHECK_EQ

Done.

https://codereview.chromium.org/2327643003/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/loader/DocumentLoader.cpp:327:
ALLOW_UNUSED_LOCAL(resource);
On 2016/09/12 04:33:12, yhirano (slow) wrote:
> ditto as Resource::cancelTimerFired.

Done.

https://codereview.chromium.org/2327643003/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/loader/DocumentLoader.cpp:328: DCHECK(resource ==
m_mainResource);
On 2016/09/12 04:33:12, yhirano (slow) wrote:
> DCHECK_EQ

Done.

https://codereview.chromium.org/2327643003/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/loader/DocumentLoader.cpp:408:
ALLOW_UNUSED_LOCAL(resource);
On 2016/09/12 04:33:12, yhirano (slow) wrote:
> ditto as Resource::cancelTimerFired.

Done.

https://codereview.chromium.org/2327643003/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/loader/DocumentLoader.cpp:409:
DCHECK(m_mainResource == resource);
On 2016/09/12 04:33:12, yhirano (slow) wrote:
> DCHECK_EQ

Done.

https://codereview.chromium.org/2327643003/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/loader/DocumentLoader.cpp:410:
ALLOW_UNUSED_LOCAL(handle);
On 2016/09/12 04:33:12, yhirano (slow) wrote:
> ditto as Resource::cancelTimerFired.

Done.

https://codereview.chromium.org/2327643003/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/loader/DocumentLoader.cpp:501: DCHECK(m_state <
MainResourceDone);
On 2016/09/12 04:33:12, yhirano (slow) wrote:
> DCHECK_LT

Done.

https://codereview.chromium.org/2327643003/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/loader/DocumentLoader.cpp:519:
ALLOW_UNUSED_LOCAL(resource);
On 2016/09/12 04:33:12, yhirano (slow) wrote:
> ditto as Resource::cancelTimerFired.

Done.

https://codereview.chromium.org/2327643003/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/loader/DocumentLoader.cpp:520: DCHECK(resource ==
m_mainResource);
On 2016/09/12 04:33:12, yhirano (slow) wrote:
> DCHECK_EQ

Done.

https://codereview.chromium.org/2327643003/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/loader/DocumentLoader.cpp:662: DCHECK(m_state ==
NotStarted);
On 2016/09/12 04:33:12, yhirano (slow) wrote:
> DCHECK_EQ

Done.

https://codereview.chromium.org/2327643003/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/loader/DocumentLoader.cpp:694:
ALLOW_UNUSED_LOCAL(writer);
On 2016/09/12 04:33:12, yhirano (slow) wrote:
> ditto as Resource::cancelTimerFired.

Done.

https://codereview.chromium.org/2327643003/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/loader/DocumentLoader.cpp:695: DCHECK(m_writer ==
writer);
On 2016/09/12 04:33:12, yhirano (slow) wrote:
> DCHECK_EQ

Done.

https://codereview.chromium.org/2327643003/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/loader/DocumentThreadableLoader.cpp (right):

https://codereview.chromium.org/2327643003/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/loader/DocumentThreadableLoader.cpp:421:
ALLOW_UNUSED_LOCAL(resource);
On 2016/09/12 04:33:13, yhirano (slow) wrote:
> ditto as Resource::cancelTimerFired.

Done.

https://codereview.chromium.org/2327643003/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/loader/DocumentThreadableLoader.cpp:422:
DCHECK(resource == this->resource());
On 2016/09/12 04:33:13, yhirano (slow) wrote:
> DCHECK_EQ

Done.

https://codereview.chromium.org/2327643003/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/loader/DocumentThreadableLoader.cpp:572:
ALLOW_UNUSED_LOCAL(resource);
On 2016/09/12 04:33:13, yhirano (slow) wrote:
> ditto as Resource::cancelTimerFired.

Done.

https://codereview.chromium.org/2327643003/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/loader/DocumentThreadableLoader.cpp:573:
DCHECK(resource == this->resource());
On 2016/09/12 04:33:13, yhirano (slow) wrote:
> DCHECK_EQ

Done.

https://codereview.chromium.org/2327643003/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/loader/DocumentThreadableLoader.cpp:583:
ALLOW_UNUSED_LOCAL(resource);
On 2016/09/12 04:33:13, yhirano (slow) wrote:
> ditto as Resource::cancelTimerFired.

Done.

https://codereview.chromium.org/2327643003/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/loader/DocumentThreadableLoader.cpp:584:
DCHECK(resource == this->resource());
On 2016/09/12 04:33:13, yhirano (slow) wrote:
> DCHECK_EQ

Done.

https://codereview.chromium.org/2327643003/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/loader/DocumentThreadableLoader.cpp:595:
ALLOW_UNUSED_LOCAL(resource);
On 2016/09/12 04:33:13, yhirano (slow) wrote:
> ditto as Resource::cancelTimerFired.

Done.

https://codereview.chromium.org/2327643003/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/loader/DocumentThreadableLoader.cpp:596:
DCHECK(resource == this->resource());
On 2016/09/12 04:33:13, yhirano (slow) wrote:
> DCHECK_EQ

Done.

https://codereview.chromium.org/2327643003/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/loader/DocumentThreadableLoader.cpp:604:
ALLOW_UNUSED_LOCAL(resource);
On 2016/09/12 04:33:13, yhirano (slow) wrote:
> ditto as Resource::cancelTimerFired.

Done.

https://codereview.chromium.org/2327643003/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/loader/DocumentThreadableLoader.cpp:605:
DCHECK(resource == this->resource());
On 2016/09/12 04:33:13, yhirano (slow) wrote:
> DCHECK_EQ

Done.

https://codereview.chromium.org/2327643003/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/loader/DocumentThreadableLoader.cpp:726:
ALLOW_UNUSED_LOCAL(resource);
On 2016/09/12 04:33:12, yhirano (slow) wrote:
> ditto as Resource::cancelTimerFired.

Done.

https://codereview.chromium.org/2327643003/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/loader/DocumentThreadableLoader.cpp:727:
DCHECK(resource == this->resource());
On 2016/09/12 04:33:13, yhirano (slow) wrote:
> DCHECK_EQ

Done.

https://codereview.chromium.org/2327643003/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/loader/DocumentThreadableLoader.cpp:756:
DCHECK(resource == this->resource());
On 2016/09/12 04:33:13, yhirano (slow) wrote:
> DCHECK_EQ

Done.

https://codereview.chromium.org/2327643003/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/loader/DocumentThreadableLoader.cpp:777:
DCHECK(m_options.crossOriginRequestPolicy == UseAccessControl);
On 2016/09/12 04:33:13, yhirano (slow) wrote:
> DCHECK_EQ

Done.

https://codereview.chromium.org/2327643003/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/loader/DocumentThreadableLoader.cpp:792:
ALLOW_UNUSED_LOCAL(timer);
On 2016/09/12 04:33:13, yhirano (slow) wrote:
> ditto as Resource::cancelTimerFired.

Done.

https://codereview.chromium.org/2327643003/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/loader/DocumentThreadableLoader.cpp:793:
DCHECK(timer == &m_timeoutTimer);
On 2016/09/12 04:33:12, yhirano (slow) wrote:
> DCHECK_EQ

Done.

https://codereview.chromium.org/2327643003/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/loader/FrameLoader.cpp (right):

https://codereview.chromium.org/2327643003/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/loader/FrameLoader.cpp:1129:
DCHECK(m_provisionalDocumentLoader == pdl);
On 2016/09/12 04:33:13, yhirano (slow) wrote:
> DCHECK_EQ

Done.

https://codereview.chromium.org/2327643003/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/loader/FrameLoader.cpp:1282: DCHECK(loader ==
m_documentLoader);
On 2016/09/12 04:33:13, yhirano (slow) wrote:
> DCHECK_EQ

Done.

https://codereview.chromium.org/2327643003/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/loader/FrameLoaderStateMachine.cpp (right):

https://codereview.chromium.org/2327643003/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/loader/FrameLoaderStateMachine.cpp:64:
DCHECK(m_state < state);
On 2016/09/12 04:33:13, yhirano (slow) wrote:
> DCHECK_LT

Done.

https://codereview.chromium.org/2327643003/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/loader/HttpEquiv.cpp (right):

https://codereview.chromium.org/2327643003/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/loader/HttpEquiv.cpp:24: DCHECK(!equiv.isNull()
&& !content.isNull());
On 2016/09/12 04:33:13, yhirano (slow) wrote:
> How about having two DCHECKs?

Done.

https://codereview.chromium.org/2327643003/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/loader/ImageLoader.cpp (right):

https://codereview.chromium.org/2327643003/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/loader/ImageLoader.cpp:441: DCHECK(resource ==
m_image.get());
On 2016/09/12 04:33:13, yhirano (slow) wrote:
> DCHECK_EQ

Done.

https://codereview.chromium.org/2327643003/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/loader/LinkLoader.cpp (right):

https://codereview.chromium.org/2327643003/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/loader/LinkLoader.cpp:87:
ALLOW_UNUSED_LOCAL(timer);
On 2016/09/12 04:33:14, yhirano (slow) wrote:
> ditto as Resource::cancelTimerFired.

Done.

https://codereview.chromium.org/2327643003/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/loader/LinkLoader.cpp:88: DCHECK(timer ==
&m_linkLoadTimer);
On 2016/09/12 04:33:13, yhirano (slow) wrote:
> DCHECK_EQ

Done.

https://codereview.chromium.org/2327643003/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/loader/LinkLoader.cpp:94:
ALLOW_UNUSED_LOCAL(timer);
On 2016/09/12 04:33:13, yhirano (slow) wrote:
> ditto as Resource::cancelTimerFired.

Done.

https://codereview.chromium.org/2327643003/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/loader/LinkLoader.cpp:95: DCHECK(timer ==
&m_linkLoadingErrorTimer);
On 2016/09/12 04:33:13, yhirano (slow) wrote:
> DCHECK_EQ

Done.

https://codereview.chromium.org/2327643003/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/loader/LinkLoader.cpp:109:
DCHECK(this->resource() == resource);
On 2016/09/12 04:33:13, yhirano (slow) wrote:
> DCHECK_EQ

Done.

https://codereview.chromium.org/2327643003/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/loader/LinkLoader.cpp:178: DCHECK(as.lower() ==
as);
On 2016/09/12 04:33:13, yhirano (slow) wrote:
> DCHECK_EQ

Done.

https://codereview.chromium.org/2327643003/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/loader/LinkPreloadResourceClients.h (right):

https://codereview.chromium.org/2327643003/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/loader/LinkPreloadResourceClients.h:59:
DCHECK(this->resource() == resource);
On 2016/09/12 04:33:14, yhirano (slow) wrote:
> DCHECK_EQ

Done.

https://codereview.chromium.org/2327643003/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/loader/LinkPreloadResourceClients.h:92:
DCHECK(this->resource() == resource);
On 2016/09/12 04:33:14, yhirano (slow) wrote:
> DCHECK_EQ

Done.

https://codereview.chromium.org/2327643003/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/loader/LinkPreloadResourceClients.h:125:
DCHECK(this->resource() == toImageResource(resource));
On 2016/09/12 04:33:14, yhirano (slow) wrote:
> DCHECK_EQ

Done.

https://codereview.chromium.org/2327643003/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/loader/LinkPreloadResourceClients.h:158:
DCHECK(this->resource() == toFontResource(resource));
On 2016/09/12 04:33:14, yhirano (slow) wrote:
> DCHECK_EQ

Done.

https://codereview.chromium.org/2327643003/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/loader/LinkPreloadResourceClients.h:191:
DCHECK(this->resource() == toRawResource(resource));
On 2016/09/12 04:33:14, yhirano (slow) wrote:
> DCHECK_EQ

Done.

https://codereview.chromium.org/2327643003/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/loader/TextTrackLoader.cpp (right):

https://codereview.chromium.org/2327643003/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/loader/TextTrackLoader.cpp:54:
ALLOW_UNUSED_LOCAL(timer);
On 2016/09/12 04:33:14, yhirano (slow) wrote:
> ditto as Resource::cancelTimerFired.

Done.

https://codereview.chromium.org/2327643003/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/loader/TextTrackLoader.cpp:55: DCHECK(timer ==
&m_cueLoadTimer);
On 2016/09/12 04:33:14, yhirano (slow) wrote:
> DCHECK_EQ

Done.

https://codereview.chromium.org/2327643003/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/loader/TextTrackLoader.cpp:73:
DCHECK(this->resource() == resource);
On 2016/09/12 04:33:14, yhirano (slow) wrote:
> DCHECK_EQ

Done.

https://codereview.chromium.org/2327643003/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/loader/TextTrackLoader.cpp:93:
DCHECK(this->resource() == resource);
On 2016/09/12 04:33:14, yhirano (slow) wrote:
> DCHECK_EQ

Done.

[tkent, 2016-09-13 08:50:53]

https://codereview.chromium.org/2327643003/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/fetch/Resource.cpp (right):

https://codereview.chromium.org/2327643003/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/fetch/Resource.cpp:754:
ALLOW_UNUSED_LOCAL(timer);
On 2016/09/13 at 08:43:19, hiroshige wrote:
> On 2016/09/12 04:33:12, yhirano (slow) wrote:
> > Is this needed? DCHECK requires its expectation as well-formed even if
> > DCHECK_IS_ON is false, and that means the expression is evaluated by the
> > compiler, I guess?
> 
> I put ALLOW_UNUSED_LOCAL() based on a comment in Assertions.h:
>
https://codesearch.chromium.org/chromium/src/third_party/WebKit/Source/wtf/As...
> 
> I removed ALLOW_UNUSED_LOCAL()s in Patch Set 5 and 6, and they passed on bots.
> 
> tkent@, how do you think about yhirano@'s comment?
> Do we have specific bots/builders where compilation fails without
ALLOW_UNUSED_LOCAL()?

AFAIK we don't need to add ALLOW_UNUSED_LOCAL() on replacing ASSERT() with
DCHECK*(). The comment in Assertions.h is wrong.

[tkent, 2016-09-13 08:52:09]

https://codereview.chromium.org/2327643003/diff/100001/third_party/WebKit/Sou...
File third_party/WebKit/Source/core/fetch/CSSStyleSheetResource.cpp (right):

https://codereview.chromium.org/2327643003/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/fetch/CSSStyleSheetResource.cpp:179: DCHECK(sheet
&& sheet->isCacheableForResource());
Split it to who DCHECKs.

https://codereview.chromium.org/2327643003/diff/100001/third_party/WebKit/Sou...
File third_party/WebKit/Source/core/loader/DocumentWriter.cpp (right):

https://codereview.chromium.org/2327643003/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/loader/DocumentWriter.cpp:115: DCHECK(m_parser &&
!m_parser->isStopped());
Split it to two DCHECKs

[tkent, 2016-09-13 08:53:03]

https://codereview.chromium.org/2327643003/diff/100001/third_party/WebKit/Sou...
File third_party/WebKit/Source/core/fetch/CSSStyleSheetResource.cpp (right):

https://codereview.chromium.org/2327643003/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/fetch/CSSStyleSheetResource.cpp:179: DCHECK(sheet
&& sheet->isCacheableForResource());
On 2016/09/13 at 08:52:09, tkent wrote:
> Split it to who DCHECKs.

oops, who -> two

[hiroshige, 2016-09-13 09:30:51]

https://codereview.chromium.org/2327643003/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/fetch/Resource.cpp (right):

https://codereview.chromium.org/2327643003/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/fetch/Resource.cpp:754:
ALLOW_UNUSED_LOCAL(timer);
On 2016/09/13 08:50:52, tkent wrote:
> On 2016/09/13 at 08:43:19, hiroshige wrote:
> > On 2016/09/12 04:33:12, yhirano (slow) wrote:
> > > Is this needed? DCHECK requires its expectation as well-formed even if
> > > DCHECK_IS_ON is false, and that means the expression is evaluated by the
> > > compiler, I guess?
> > 
> > I put ALLOW_UNUSED_LOCAL() based on a comment in Assertions.h:
> >
>
https://codesearch.chromium.org/chromium/src/third_party/WebKit/Source/wtf/As...
> > 
> > I removed ALLOW_UNUSED_LOCAL()s in Patch Set 5 and 6, and they passed on
bots.
> > 
> > tkent@, how do you think about yhirano@'s comment?
> > Do we have specific bots/builders where compilation fails without
> ALLOW_UNUSED_LOCAL()?
> 
> AFAIK we don't need to add ALLOW_UNUSED_LOCAL() on replacing ASSERT() with
> DCHECK*(). The comment in Assertions.h is wrong.
> 

Thanks! I'll create a separate CL to fix Assertions.h.

https://codereview.chromium.org/2327643003/diff/100001/third_party/WebKit/Sou...
File third_party/WebKit/Source/core/fetch/CSSStyleSheetResource.cpp (right):

https://codereview.chromium.org/2327643003/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/fetch/CSSStyleSheetResource.cpp:179: DCHECK(sheet
&& sheet->isCacheableForResource());
On 2016/09/13 08:52:09, tkent wrote:
> Split it to who DCHECKs.

Done.

https://codereview.chromium.org/2327643003/diff/100001/third_party/WebKit/Sou...
File third_party/WebKit/Source/core/loader/DocumentWriter.cpp (right):

https://codereview.chromium.org/2327643003/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/loader/DocumentWriter.cpp:115: DCHECK(m_parser &&
!m_parser->isStopped());
On 2016/09/13 08:52:09, tkent wrote:
> Split it to two DCHECKs

Done.

[hiroshige, 2016-09-13 09:32:17]

Description was changed from

==========
Replace ASSERT*() with DCHECK*() in core/fetch/ and core/loader/

sed -i 's/ ASSERT(/ DCHECK(/g'
sed -i 's/ RELEASE_ASSERT(/ CHECK(/g'
sed -i 's/ ASSERT_NOT_REACHED(/ NOTREACHED(/g'
sed -i 's/ ASSERT_WITH_SECURITY_IMPLICATION(/ SECURITY_DCHECK(/g'
perl -npe '$_ =~ s/^(\s+)ASSERT_UNUSED\((.*?),
(.*)\);$/$1ALLOW_UNUSED_LOCAL($2);\n$1DCHECK($3);/g'

for `find third_party/WebKit/Source/core/{fetch,loader}/ -name '*.*'`.

This CL replaces DCHECK(a == b) with DCHECK_EQ(a, b) etc. manually.

BUG=645395, 596760
==========

to

==========
Replace ASSERT*() with DCHECK*() in core/fetch/ and core/loader/

sed -i 's/ ASSERT(/ DCHECK(/g'
sed -i 's/ RELEASE_ASSERT(/ CHECK(/g'
sed -i 's/ ASSERT_NOT_REACHED(/ NOTREACHED(/g'
sed -i 's/ ASSERT_WITH_SECURITY_IMPLICATION(/ SECURITY_DCHECK(/g'
perl -npe '$_ =~ s/ ASSERT_UNUSED\((.*?), (.*)\);$/DCHECK($2);/g'

for `find third_party/WebKit/Source/core/{fetch,loader}/ -name '*.*'`.

This CL replaces
- DCHECK(a == b) with DCHECK_EQ(a, b)
- DCHECK(a && b) with DCHECK(a) and DCHECK(b)
etc. manually.

BUG=645395, 596760
==========

[hiroshige, 2016-09-13 09:32:36]

Description was changed from

==========
Replace ASSERT*() with DCHECK*() in core/fetch/ and core/loader/

sed -i 's/ ASSERT(/ DCHECK(/g'
sed -i 's/ RELEASE_ASSERT(/ CHECK(/g'
sed -i 's/ ASSERT_NOT_REACHED(/ NOTREACHED(/g'
sed -i 's/ ASSERT_WITH_SECURITY_IMPLICATION(/ SECURITY_DCHECK(/g'
perl -npe '$_ =~ s/ ASSERT_UNUSED\((.*?), (.*)\);$/DCHECK($2);/g'

for `find third_party/WebKit/Source/core/{fetch,loader}/ -name '*.*'`.

This CL replaces
- DCHECK(a == b) with DCHECK_EQ(a, b)
- DCHECK(a && b) with DCHECK(a) and DCHECK(b)
etc. manually.

BUG=645395, 596760
==========

to

==========
Replace ASSERT*() with DCHECK*() in core/fetch/ and core/loader/

sed -i 's/ ASSERT(/ DCHECK(/g'
sed -i 's/ RELEASE_ASSERT(/ CHECK(/g'
sed -i 's/ ASSERT_NOT_REACHED(/ NOTREACHED(/g'
sed -i 's/ ASSERT_WITH_SECURITY_IMPLICATION(/ SECURITY_DCHECK(/g'
perl -npe '$_ =~ s/ASSERT_UNUSED\((.*?), (.*)\);$/DCHECK($2);/g'

for `find third_party/WebKit/Source/core/{fetch,loader}/ -name '*.*'`.

This CL replaces
- DCHECK(a == b) with DCHECK_EQ(a, b)
- DCHECK(a && b) with DCHECK(a) and DCHECK(b)
etc. manually.

BUG=645395, 596760
==========

[yhirano, 2016-09-14 11:50:28]

lgtm

[hiroshige, 2016-09-14 15:55:01]

The CQ bit was checked by hiroshige@chromium.org

[commit-bot: I haz the power, 2016-09-14 15:55:16]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-14 17:39:18]

Description was changed from

==========
Replace ASSERT*() with DCHECK*() in core/fetch/ and core/loader/

sed -i 's/ ASSERT(/ DCHECK(/g'
sed -i 's/ RELEASE_ASSERT(/ CHECK(/g'
sed -i 's/ ASSERT_NOT_REACHED(/ NOTREACHED(/g'
sed -i 's/ ASSERT_WITH_SECURITY_IMPLICATION(/ SECURITY_DCHECK(/g'
perl -npe '$_ =~ s/ASSERT_UNUSED\((.*?), (.*)\);$/DCHECK($2);/g'

for `find third_party/WebKit/Source/core/{fetch,loader}/ -name '*.*'`.

This CL replaces
- DCHECK(a == b) with DCHECK_EQ(a, b)
- DCHECK(a && b) with DCHECK(a) and DCHECK(b)
etc. manually.

BUG=645395, 596760
==========

to

==========
Replace ASSERT*() with DCHECK*() in core/fetch/ and core/loader/

sed -i 's/ ASSERT(/ DCHECK(/g'
sed -i 's/ RELEASE_ASSERT(/ CHECK(/g'
sed -i 's/ ASSERT_NOT_REACHED(/ NOTREACHED(/g'
sed -i 's/ ASSERT_WITH_SECURITY_IMPLICATION(/ SECURITY_DCHECK(/g'
perl -npe '$_ =~ s/ASSERT_UNUSED\((.*?), (.*)\);$/DCHECK($2);/g'

for `find third_party/WebKit/Source/core/{fetch,loader}/ -name '*.*'`.

This CL replaces
- DCHECK(a == b) with DCHECK_EQ(a, b)
- DCHECK(a && b) with DCHECK(a) and DCHECK(b)
etc. manually.

BUG=645395, 596760
==========

[commit-bot: I haz the power, 2016-09-14 17:39:20]

Committed patchset #8 (id:140001)

[commit-bot: I haz the power, 2016-09-14 17:42:17]

Description was changed from

==========
Replace ASSERT*() with DCHECK*() in core/fetch/ and core/loader/

sed -i 's/ ASSERT(/ DCHECK(/g'
sed -i 's/ RELEASE_ASSERT(/ CHECK(/g'
sed -i 's/ ASSERT_NOT_REACHED(/ NOTREACHED(/g'
sed -i 's/ ASSERT_WITH_SECURITY_IMPLICATION(/ SECURITY_DCHECK(/g'
perl -npe '$_ =~ s/ASSERT_UNUSED\((.*?), (.*)\);$/DCHECK($2);/g'

for `find third_party/WebKit/Source/core/{fetch,loader}/ -name '*.*'`.

This CL replaces
- DCHECK(a == b) with DCHECK_EQ(a, b)
- DCHECK(a && b) with DCHECK(a) and DCHECK(b)
etc. manually.

BUG=645395, 596760
==========

to

==========
Replace ASSERT*() with DCHECK*() in core/fetch/ and core/loader/

sed -i 's/ ASSERT(/ DCHECK(/g'
sed -i 's/ RELEASE_ASSERT(/ CHECK(/g'
sed -i 's/ ASSERT_NOT_REACHED(/ NOTREACHED(/g'
sed -i 's/ ASSERT_WITH_SECURITY_IMPLICATION(/ SECURITY_DCHECK(/g'
perl -npe '$_ =~ s/ASSERT_UNUSED\((.*?), (.*)\);$/DCHECK($2);/g'

for `find third_party/WebKit/Source/core/{fetch,loader}/ -name '*.*'`.

This CL replaces
- DCHECK(a == b) with DCHECK_EQ(a, b)
- DCHECK(a && b) with DCHECK(a) and DCHECK(b)
etc. manually.

BUG=645395, 596760

Committed: https://crrev.com/b4c242bce2dd77f07a5d2b051088688f1ebbab86
Cr-Commit-Position: refs/heads/master@{#418606}
==========

[commit-bot: I haz the power, 2016-09-14 17:42:18]

Patchset 8 (id:??) landed as
https://crrev.com/b4c242bce2dd77f07a5d2b051088688f1ebbab86
Cr-Commit-Position: refs/heads/master@{#418606}