Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Unified Diff: third_party/WebKit/Source/core/fetch/ScriptResource.cpp

Issue 2327643003: Replace ASSERT*() with DCHECK*() in core/fetch/ and core/loader/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase. Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/fetch/ScriptResource.cpp
diff --git a/third_party/WebKit/Source/core/fetch/ScriptResource.cpp b/third_party/WebKit/Source/core/fetch/ScriptResource.cpp
index 194171c628d08120186714b973df1b925eb13e8b..962139956bc935f45c4330f964c49c6a930d2e8f 100644
--- a/third_party/WebKit/Source/core/fetch/ScriptResource.cpp
+++ b/third_party/WebKit/Source/core/fetch/ScriptResource.cpp
@@ -39,7 +39,7 @@ namespace blink {
ScriptResource* ScriptResource::fetch(FetchRequest& request, ResourceFetcher* fetcher)
{
- ASSERT(request.resourceRequest().frameType() == WebURLRequest::FrameTypeNone);
+ DCHECK_EQ(request.resourceRequest().frameType(), WebURLRequest::FrameTypeNone);
request.mutableResourceRequest().setRequestContext(WebURLRequest::RequestContextScript);
ScriptResource* resource = toScriptResource(fetcher->requestResource(request, ScriptResourceFactory()));
if (resource && !request.integrityMetadata().isEmpty())
@@ -59,7 +59,7 @@ ScriptResource::~ScriptResource()
void ScriptResource::didAddClient(ResourceClient* client)
{
- ASSERT(ScriptResourceClient::isExpectedType(client));
+ DCHECK(ScriptResourceClient::isExpectedType(client));
Resource::didAddClient(client);
}
@@ -82,7 +82,7 @@ void ScriptResource::onMemoryDump(WebMemoryDumpLevelOfDetail levelOfDetail, WebP
const String& ScriptResource::script()
{
- ASSERT(isLoaded());
+ DCHECK(isLoaded());
if (m_script.isNull() && data()) {
String script = decodedText();
@@ -109,7 +109,7 @@ bool ScriptResource::mimeTypeAllowedByNosniff() const
void ScriptResource::setIntegrityDisposition(ScriptIntegrityDisposition disposition)
{
- ASSERT(disposition != ScriptIntegrityDisposition::NotChecked);
+ DCHECK_NE(disposition, ScriptIntegrityDisposition::NotChecked);
m_integrityDisposition = disposition;
}
bool ScriptResource::mustRefetchDueToIntegrityMetadata(const FetchRequest& request) const

Powered by Google App Engine
This is Rietveld 408576698