Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(215)

Unified Diff: third_party/WebKit/Source/core/fetch/ImageResource.cpp

Issue 2327643003: Replace ASSERT*() with DCHECK*() in core/fetch/ and core/loader/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase. Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/fetch/ImageResource.cpp
diff --git a/third_party/WebKit/Source/core/fetch/ImageResource.cpp b/third_party/WebKit/Source/core/fetch/ImageResource.cpp
index 9a98251a0e375223dae14098aef57c85805722a0..780a73dbfa75ca80fbe14569bea57d3dff4b2ad6 100644
--- a/third_party/WebKit/Source/core/fetch/ImageResource.cpp
+++ b/third_party/WebKit/Source/core/fetch/ImageResource.cpp
@@ -157,14 +157,14 @@ void ImageResource::addObserver(ImageResourceObserver* observer)
void ImageResource::removeObserver(ImageResourceObserver* observer)
{
- ASSERT(observer);
+ DCHECK(observer);
if (m_observers.contains(observer))
m_observers.remove(observer);
else if (m_finishedObservers.contains(observer))
m_finishedObservers.remove(observer);
else
- ASSERT_NOT_REACHED();
+ NOTREACHED();
didRemoveClientOrObserver();
}
@@ -443,8 +443,8 @@ void ImageResource::error(const ResourceError& error)
void ImageResource::responseReceived(const ResourceResponse& response, std::unique_ptr<WebDataConsumerHandle> handle)
{
- ASSERT(!handle);
- ASSERT(!m_multipartParser);
+ DCHECK(!handle);
+ DCHECK(!m_multipartParser);
// If there's no boundary, just handle the request normally.
if (response.isMultipart() && !response.multipartBoundary().isEmpty())
m_multipartParser = new MultipartImageResourceParser(response, response.multipartBoundary(), this);
@@ -550,7 +550,7 @@ void ImageResource::changedInRect(const blink::Image* image, const IntRect& rect
void ImageResource::onePartInMultipartReceived(const ResourceResponse& response)
{
- ASSERT(m_multipartParser);
+ DCHECK(m_multipartParser);
setResponse(response);
if (m_multipartParsingState == MultipartParsingState::WaitingForFirstPart) {
@@ -576,7 +576,7 @@ void ImageResource::onePartInMultipartReceived(const ResourceResponse& response)
void ImageResource::multipartDataReceived(const char* bytes, size_t size)
{
- ASSERT(m_multipartParser);
+ DCHECK(m_multipartParser);
Resource::appendData(bytes, size);
}
« no previous file with comments | « third_party/WebKit/Source/core/fetch/FontResource.cpp ('k') | third_party/WebKit/Source/core/fetch/LinkFetchResource.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698