Replace ASSERT*() with DCHECK*() in core/fetch/ and core/loader/

third_party/WebKit/Source/core/loader/DocumentLoadTiming.cpp

 /*
  * Copyright (C) 2011 Google, Inc. All Rights Reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
  *    notice, this list of conditions and the following disclaimer in the
@@ skipping 84 matching lines @@
     if (!pseudoWallTime)
         return 0.0;
     return m_referenceMonotonicTime + pseudoWallTime - m_referenceWallTime;
 }
 
 void DocumentLoadTiming::markNavigationStart()
 {
     // Allow the embedder to override navigationStart before we record it if
     // they have a more accurate timestamp.
     if (m_navigationStart) {
-        ASSERT(m_referenceMonotonicTime && m_referenceWallTime);
+        DCHECK(m_referenceMonotonicTime && m_referenceWallTime);
         return;
     }
-    ASSERT(!m_navigationStart && !m_referenceMonotonicTime && !m_referenceWallTime);
+    DCHECK(!m_navigationStart && !m_referenceMonotonicTime && !m_referenceWallTime);

[yhirano, 2016/09/12 04:33:12]

How about having three DCHECKs?

[hiroshige, 2016/09/13 08:43:19]

Done.

     ensureReferenceTimesSet();
     m_navigationStart = m_referenceMonotonicTime;
     TRACE_EVENT_MARK_WITH_TIMESTAMP1("blink.user_timing", "navigationStart", m_navigationStart, "frame", frame());
     notifyDocumentTimingChanged();
 }
 
 void DocumentLoadTiming::setNavigationStart(double navigationStart)
 {
     // |m_referenceMonotonicTime| and |m_referenceWallTime| represent
     // navigationStart. We must set these to the current time if they haven't
     // been set yet in order to have a valid reference time in both units.
     ensureReferenceTimesSet();
     m_navigationStart = navigationStart;
     TRACE_EVENT_MARK_WITH_TIMESTAMP1("blink.user_timing", "navigationStart", m_navigationStart, "frame", frame());
 
     // The reference times are adjusted based on the embedder's navigationStart.
-    ASSERT(m_referenceMonotonicTime && m_referenceWallTime);
+    DCHECK(m_referenceMonotonicTime && m_referenceWallTime);
     m_referenceWallTime = monotonicTimeToPseudoWallTime(navigationStart);
     m_referenceMonotonicTime = navigationStart;
     notifyDocumentTimingChanged();
 }
 
 void DocumentLoadTiming::addRedirect(const KURL& redirectingUrl, const KURL& redirectedUrl)
 {
     m_redirectCount++;
     if (!m_redirectStart) {
         setRedirectStart(m_fetchStart);
@@ skipping 68 matching lines @@
 }
 
 void DocumentLoadTiming::markRedirectEnd()
 {
     m_redirectEnd = monotonicallyIncreasingTime();
     TRACE_EVENT_MARK_WITH_TIMESTAMP1("blink.user_timing", "redirectEnd", m_redirectEnd, "frame", frame());
     notifyDocumentTimingChanged();
 }
 
 } // namespace blink