Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1217)

Unified Diff: third_party/WebKit/Source/core/fetch/DocumentResource.cpp

Issue 2327643003: Replace ASSERT*() with DCHECK*() in core/fetch/ and core/loader/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase. Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/fetch/DocumentResource.cpp
diff --git a/third_party/WebKit/Source/core/fetch/DocumentResource.cpp b/third_party/WebKit/Source/core/fetch/DocumentResource.cpp
index a532fdb0a17f283b4ce3cc4a18938d93847a870b..dc070ef4349848cf152f5693e77e7d15f05508c5 100644
--- a/third_party/WebKit/Source/core/fetch/DocumentResource.cpp
+++ b/third_party/WebKit/Source/core/fetch/DocumentResource.cpp
@@ -32,7 +32,7 @@ namespace blink {
DocumentResource* DocumentResource::fetchSVGDocument(FetchRequest& request, ResourceFetcher* fetcher)
{
- ASSERT(request.resourceRequest().frameType() == WebURLRequest::FrameTypeNone);
+ DCHECK_EQ(request.resourceRequest().frameType(), WebURLRequest::FrameTypeNone);
request.mutableResourceRequest().setRequestContext(WebURLRequest::RequestContextImage);
return toDocumentResource(fetcher->requestResource(request, SVGDocumentResourceFactory()));
}
@@ -41,7 +41,7 @@ DocumentResource::DocumentResource(const ResourceRequest& request, Type type, co
: TextResource(request, type, options, "application/xml", String())
{
// FIXME: We'll support more types to support HTMLImports.
- ASSERT(type == SVGDocument);
+ DCHECK_EQ(type, SVGDocument);
}
DocumentResource::~DocumentResource()
@@ -66,7 +66,7 @@ void DocumentResource::checkNotify()
bool DocumentResource::mimeTypeAllowed() const
{
- ASSERT(getType() == SVGDocument);
+ DCHECK_EQ(getType(), SVGDocument);
AtomicString mimeType = response().mimeType();
if (response().isHTTP())
mimeType = httpContentType();
@@ -83,7 +83,7 @@ Document* DocumentResource::createDocument(const KURL& url)
return XMLDocument::createSVG(DocumentInit(url));
default:
// FIXME: We'll add more types to support HTMLImports.
- ASSERT_NOT_REACHED();
+ NOTREACHED();
return nullptr;
}
}
« no previous file with comments | « third_party/WebKit/Source/core/fetch/CSSStyleSheetResource.cpp ('k') | third_party/WebKit/Source/core/fetch/FetchRequest.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698