third_party/WebKit/Source/core/loader/FormSubmission.cpp - Issue 2327643003: Replace ASSERT*() with DCHECK*() in core/fetch/ and core/loader/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/loader/FormSubmission.cpp

Issue 2327643003: Replace ASSERT*() with DCHECK*() in core/fetch/ and core/loader/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase. Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/loader/DocumentWriter.cpp ('k') | third_party/WebKit/Source/core/loader/FrameFetchContext.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/loader/FormSubmission.cpp

diff --git a/third_party/WebKit/Source/core/loader/FormSubmission.cpp b/third_party/WebKit/Source/core/loader/FormSubmission.cpp

index de7831e1164a44d7164080ed4008675ffb32e21b..3d26a2b8e3802c49e142abdd6fb9bdba9938d018 100644

--- a/third_party/WebKit/Source/core/loader/FormSubmission.cpp

+++ b/third_party/WebKit/Source/core/loader/FormSubmission.cpp

@@ -129,7 +129,7 @@ String FormSubmission::Attributes::methodString(SubmitMethod method)

case DialogMethod:

return "dialog";

}

- ASSERT_NOT_REACHED();

+ NOTREACHED();

return emptyString();

}

@@ -164,7 +164,7 @@ inline FormSubmission::FormSubmission(const String& result)

FormSubmission* FormSubmission::create(HTMLFormElement* form, const Attributes& attributes, Event* event)

{

- ASSERT(form);

+ DCHECK(form);

HTMLFormControlElement* submitButton = 0;

if (event && event->target()) {

@@ -223,7 +223,7 @@ FormSubmission* FormSubmission::create(HTMLFormElement* form, const Attributes&

bool containsPasswordData = false;

for (unsigned i = 0; i < form->associatedElements().size(); ++i) {

FormAssociatedElement* control = form->associatedElements()[i];

- ASSERT(control);

+ DCHECK(control);

HTMLElement& element = toHTMLElement(*control);

if (!element.isDisabledFormControl())

control->appendToFormData(*domFormData);