Replace ASSERT*() with DCHECK*() in core/fetch/ and core/loader/

third_party/WebKit/Source/core/loader/LinkLoader.cpp

 /*
  * Copyright (C) 2011 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 66 matching lines @@
     , m_linkLoadingErrorTimer(this, &LinkLoader::linkLoadingErrorTimerFired)
 {
 }
 
 LinkLoader::~LinkLoader()
 {
 }
 
 void LinkLoader::linkLoadTimerFired(TimerBase* timer)
 {
-    ASSERT_UNUSED(timer, timer == &m_linkLoadTimer);
+    ALLOW_UNUSED_LOCAL(timer);

[yhirano, 2016/09/12 04:33:14]

ditto as Resource::cancelTimerFired.

[hiroshige, 2016/09/13 08:43:21]

Done.

+    DCHECK(timer == &m_linkLoadTimer);

[yhirano, 2016/09/12 04:33:13]

DCHECK_EQ

[hiroshige, 2016/09/13 08:43:21]

Done.

     m_client->linkLoaded();
 }
 
 void LinkLoader::linkLoadingErrorTimerFired(TimerBase* timer)
 {
-    ASSERT_UNUSED(timer, timer == &m_linkLoadingErrorTimer);
+    ALLOW_UNUSED_LOCAL(timer);

[yhirano, 2016/09/12 04:33:13]

ditto as Resource::cancelTimerFired.

[hiroshige, 2016/09/13 08:43:21]

Done.

+    DCHECK(timer == &m_linkLoadingErrorTimer);

[yhirano, 2016/09/12 04:33:13]

DCHECK_EQ

[hiroshige, 2016/09/13 08:43:21]

Done.

     m_client->linkLoadingErrored();
 }
 
 void LinkLoader::triggerEvents(const Resource* resource)
 {
     if (resource->errorOccurred())
         m_linkLoadingErrorTimer.startOneShot(0, BLINK_FROM_HERE);
     else
         m_linkLoadTimer.startOneShot(0, BLINK_FROM_HERE);
 }
 
 void LinkLoader::notifyFinished(Resource* resource)
 {
-    ASSERT(this->resource() == resource);
+    DCHECK(this->resource() == resource);

[yhirano, 2016/09/12 04:33:13]

DCHECK_EQ

[hiroshige, 2016/09/13 08:43:21]

Done.

 
     triggerEvents(resource);
     clearResource();
 }
 
 void LinkLoader::didStartPrerender()
 {
     m_client->didStartLinkPrerender();
 }
 
@@ skipping 48 matching lines @@
                 document.addConsoleMessage(ConsoleMessage::create(OtherMessageSource, DebugMessageLevel,
                     String("Preconnect CORS setting is ") + String((crossOrigin == CrossOriginAttributeAnonymous) ? "anonymous" : "use-credentials")));
             }
         }
         networkHintsInterface.preconnectHost(href, crossOrigin);
     }
 }
 
 bool LinkLoader::getResourceTypeFromAsAttribute(const String& as, Resource::Type& type)
 {
-    ASSERT(as.lower() == as);
+    DCHECK(as.lower() == as);

[yhirano, 2016/09/12 04:33:13]

DCHECK_EQ

[hiroshige, 2016/09/13 08:43:21]

Done.

     if (as == "image") {
         type = Resource::Image;
     } else if (as == "script") {
         type = Resource::Script;
     } else if (as == "style") {
         type = Resource::CSSStyleSheet;
     } else if (as == "media") {
         type = Resource::Media;
     } else if (as == "font") {
         type = Resource::Font;
@@ skipping 23 matching lines @@
         break;
     case Resource::Font:
         m_linkPreloadResourceClient = LinkPreloadFontResourceClient::create(this, toFontResource(resource));
         break;
     case Resource::Media:
     case Resource::TextTrack:
     case Resource::Raw:
         m_linkPreloadResourceClient = LinkPreloadRawResourceClient::create(this, toRawResource(resource));
         break;
     default:
-        ASSERT_NOT_REACHED();
+        NOTREACHED();
     }
 }
 
 static bool isSupportedType(Resource::Type resourceType, const String& mimeType)
 {
     if (mimeType.isEmpty())
         return true;
     switch (resourceType) {
     case Resource::Image:
         return MIMETypeRegistry::isSupportedImagePrefixedMIMEType(mimeType);
     case Resource::Script:
         return MIMETypeRegistry::isSupportedJavaScriptMIMEType(mimeType);
     case Resource::CSSStyleSheet:
         return MIMETypeRegistry::isSupportedStyleSheetMIMEType(mimeType);
     case Resource::Font:
         return MIMETypeRegistry::isSupportedFontMIMEType(mimeType);
     case Resource::Media:
         return MIMETypeRegistry::isSupportedMediaSourceMIMEType(mimeType, String());
     case Resource::TextTrack:
         return MIMETypeRegistry::isSupportedTextTrackMIMEType(mimeType);
     case Resource::Raw:
         return true;
     default:
-        ASSERT_NOT_REACHED();
+        NOTREACHED();
     }
     return false;
 }
 
 static Resource* preloadIfNeeded(const LinkRelAttribute& relAttribute, const KURL& href, Document& document, const String& as, const String& mimeType,
     const String& media, CrossOriginAttributeValue crossOrigin, LinkCaller caller, bool& errorOccurred, ViewportDescription* viewportDescription)
 {
     if (!document.loader() || !relAttribute.isLinkPreload())
         return nullptr;
 
@@ skipping 137 matching lines @@
 DEFINE_TRACE(LinkLoader)
 {
     visitor->trace(m_client);
     visitor->trace(m_prerender);
     visitor->trace(m_linkPreloadResourceClient);
     ResourceOwner<Resource, ResourceClient>::trace(visitor);
     PrerenderClient::trace(visitor);
 }
 
 } // namespace blink