Removed const from classes arrays in Observatory

Removed const from classes arrays in Observatory

R=turnidge@google.com

Committed: https://github.com/dart-lang/sdk/commit/1a1224b1d3727c5b8a0d618940f3d47eaecadefa

[cbernaschina, 2016-08-30 22:15:00]

cbernaschina@google.com changed reviewers:
+ johnmccutchan@google.com, rmacnak@google.com, turnidge@google.com

[turnidge, 2016-08-30 22:31:02]

lgtm

lgtm

It occurs to me that we should take all of the content class names like...

  'content-centered-big'

...and we should replace them with named constants to avoid accidental typos...

  contentCenteredBig or kContentCenteredBig or whatever our style is.

This is not a comment for this cl or even something you need to do, but it might
give us a little more protection against typos.

[cbernaschina, 2016-08-30 22:34:28]

On 2016/08/30 22:31:02, turnidge wrote:
> lgtm
> 
> lgtm
> 
> It occurs to me that we should take all of the content class names like...
> 
>   'content-centered-big'
> 
> ...and we should replace them with named constants to avoid accidental
typos...
> 
>   contentCenteredBig or kContentCenteredBig or whatever our style is.
> 
> This is not a comment for this cl or even something you need to do, but it
might
> give us a little more protection against typos.

I think that an utility class like the one introduced for Uris can do it.
We can even store the pre-computed lists there.

new DivElement()..classes = Styles.contentCenteredBig
or
new DivElement()..classes = Classes.contentCenteredBig

[cbernaschina, 2016-08-30 22:38:16]

Description was changed from

==========
Removed const from classes arrays in Observatory
==========

to

==========
Removed const from classes arrays in Observatory

R=turnidge@google.com

Committed:
https://github.com/dart-lang/sdk/commit/1a1224b1d3727c5b8a0d618940f3d47eaecadefa
==========

[cbernaschina, 2016-08-30 22:38:18]

Committed patchset #1 (id:1) manually as
1a1224b1d3727c5b8a0d618940f3d47eaecadefa (presubmit successful).

[turnidge, 2016-08-31 03:02:31]

Yeah, that sounds like a good idea.

On 2016/08/30 22:34:28, cbernaschina wrote:
> On 2016/08/30 22:31:02, turnidge wrote:
> > lgtm
> > 
> > lgtm
> > 
> > It occurs to me that we should take all of the content class names like...
> > 
> >   'content-centered-big'
> > 
> > ...and we should replace them with named constants to avoid accidental
> typos...
> > 
> >   contentCenteredBig or kContentCenteredBig or whatever our style is.
> > 
> > This is not a comment for this cl or even something you need to do, but it
> might
> > give us a little more protection against typos.
> 
> I think that an utility class like the one introduced for Uris can do it.
> We can even store the pre-computed lists there.
> 
> new DivElement()..classes = Styles.contentCenteredBig
> or
> new DivElement()..classes = Classes.contentCenteredBig