Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(245)

Side by Side Diff: runtime/observatory/lib/src/elements/field_view.dart

Issue 2298563002: Removed const from classes arrays in Observatory (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 library field_view_element; 5 library field_view_element;
6 6
7 import 'dart:async'; 7 import 'dart:async';
8 import 'dart:html'; 8 import 'dart:html';
9 import 'package:observatory/models.dart' as M; 9 import 'package:observatory/models.dart' as M;
10 import 'package:observatory/src/elements/class_ref.dart'; 10 import 'package:observatory/src/elements/class_ref.dart';
(...skipping 137 matching lines...) Expand 10 before | Expand all | Expand 10 after
148 header += 'const '; 148 header += 'const ';
149 } 149 }
150 if (_field.declaredType.name == 'dynamic'){ 150 if (_field.declaredType.name == 'dynamic'){
151 header += 'var'; 151 header += 'var';
152 } else { 152 } else {
153 header += _field.declaredType.name; 153 header += _field.declaredType.name;
154 } 154 }
155 children = [ 155 children = [
156 new NavBarElement(queue: _r.queue) 156 new NavBarElement(queue: _r.queue)
157 ..children = _createMenu(), 157 ..children = _createMenu(),
158 new DivElement()..classes = const ['content-centered-big'] 158 new DivElement()..classes = ['content-centered-big']
159 ..children = [ 159 ..children = [
160 new HeadingElement.h2()..text = '$header ${field.name}', 160 new HeadingElement.h2()..text = '$header ${field.name}',
161 new HRElement(), 161 new HRElement(),
162 new ObjectCommonElement(_isolate, _field, _retainedSizes, 162 new ObjectCommonElement(_isolate, _field, _retainedSizes,
163 _reachableSizes, _references, _retainingPaths, 163 _reachableSizes, _references, _retainingPaths,
164 _instances, queue: _r.queue), 164 _instances, queue: _r.queue),
165 new BRElement(), 165 new BRElement(),
166 new DivElement()..classes = ['memberList'] 166 new DivElement()..classes = ['memberList']
167 ..children = _createMembers(), 167 ..children = _createMembers(),
168 new HRElement(), 168 new HRElement(),
(...skipping 116 matching lines...) Expand 10 before | Expand all | Expand 10 after
285 Future _refresh() async { 285 Future _refresh() async {
286 _field = await _fields.get(_isolate, _field.id); 286 _field = await _fields.get(_isolate, _field.id);
287 if (_field.dartOwner is M.LibraryRef) { 287 if (_field.dartOwner is M.LibraryRef) {
288 _library = _field.dartOwner; 288 _library = _field.dartOwner;
289 } else if (_field.dartOwner is M.ClassRef) { 289 } else if (_field.dartOwner is M.ClassRef) {
290 _library = (await _classes.get(_isolate, _field.dartOwner.id)).library; 290 _library = (await _classes.get(_isolate, _field.dartOwner.id)).library;
291 } 291 }
292 _r.dirty(); 292 _r.dirty();
293 } 293 }
294 } 294 }
OLDNEW
« no previous file with comments | « runtime/observatory/lib/src/elements/eval_box.dart ('k') | runtime/observatory/lib/src/elements/flag_list.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698