Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(269)

Unified Diff: runtime/observatory/lib/src/elements/eval_box.dart

Issue 2298563002: Removed const from classes arrays in Observatory (Closed)
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/observatory/lib/src/elements/eval_box.dart
diff --git a/runtime/observatory/lib/src/elements/eval_box.dart b/runtime/observatory/lib/src/elements/eval_box.dart
index 004d9e041fc0f56fdf377f4d191291d8a28d6ab1..29f71f02754c51613e2bf22502e0ecdcfd6dd552 100644
--- a/runtime/observatory/lib/src/elements/eval_box.dart
+++ b/runtime/observatory/lib/src/elements/eval_box.dart
@@ -75,7 +75,7 @@ class EvalBoxElement extends HtmlElement implements Renderable {
void render() {
children = [
- new DivElement()..classes = const ['quicks']
+ new DivElement()..classes = ['quicks']
..children = _quickExpressions.map((q) =>
new ButtonElement()
..text = q
@@ -84,13 +84,13 @@ class EvalBoxElement extends HtmlElement implements Renderable {
_run();
})
),
- new DivElement()..classes = const ['heading']
+ new DivElement()..classes = ['heading']
..children = [
new FormElement()
..autocomplete = 'on'
..children = [
_multiline ? _createEvalTextArea() : _createEvalTextBox(),
- new SpanElement()..classes = const ['buttons']
+ new SpanElement()..classes = ['buttons']
..children = [
_createEvalButton(),
_createMultilineCheckbox(),
@@ -102,7 +102,7 @@ class EvalBoxElement extends HtmlElement implements Renderable {
..children = _results.reversed.map((result) =>
new TableRowElement()
..children = [
- new TableCellElement()..classes = const ['historyExpr']
+ new TableCellElement()..classes = ['historyExpr']
..children = [
new ButtonElement()..text = result.expression
..onClick.listen((_) {
@@ -110,14 +110,14 @@ class EvalBoxElement extends HtmlElement implements Renderable {
_r.dirty();
})
],
- new TableCellElement()..classes = const ['historyValue']
+ new TableCellElement()..classes = ['historyValue']
..children = [
result.isPending
? (new SpanElement()..text = 'Pending...')
: anyRef(_isolate, result.value, _instances,
queue: _r.queue)
],
- new TableCellElement()..classes = const ['historyDelete']
+ new TableCellElement()..classes = ['historyDelete']
..children = [
new ButtonElement()..text = '✖ Remove'
..onClick.listen((_) {
« no previous file with comments | « runtime/observatory/lib/src/elements/cpu_profile_table.dart ('k') | runtime/observatory/lib/src/elements/field_view.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698