Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1072)

Unified Diff: runtime/observatory/lib/src/elements/cpu_profile_table.dart

Issue 2298563002: Removed const from classes arrays in Observatory (Closed)
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/observatory/lib/src/elements/cpu_profile_table.dart
diff --git a/runtime/observatory/lib/src/elements/cpu_profile_table.dart b/runtime/observatory/lib/src/elements/cpu_profile_table.dart
index d7b09d7d0ad2929ad379a201e1d7098ee5d9f8d9..d841fc1a80441f26fb4ecbe3f6611ed9f68b1b47 100644
--- a/runtime/observatory/lib/src/elements/cpu_profile_table.dart
+++ b/runtime/observatory/lib/src/elements/cpu_profile_table.dart
@@ -215,13 +215,13 @@ class CpuProfileTableElement extends HtmlElement implements Renderable {
Element _createFunction() {
final element = new DivElement()
- ..classes = const ['function-item']
+ ..classes = ['function-item']
..children = [
- new SpanElement()..classes = const ['exclusive']
+ new SpanElement()..classes = ['exclusive']
..text = '0%',
- new SpanElement()..classes = const ['inclusive']
+ new SpanElement()..classes = ['inclusive']
..text = '0%',
- new SpanElement()..classes = const ['name']
+ new SpanElement()..classes = ['name']
];
element.onClick.listen((e) {
if (e.target is AnchorElement) {
@@ -235,19 +235,19 @@ class CpuProfileTableElement extends HtmlElement implements Renderable {
void _updateFunction(Element e, M.ProfileFunction item, int index) {
if (item == _selected) {
- e.classes = const ['function-item', 'selected'];
+ e.classes = ['function-item', 'selected'];
} else {
- e.classes = const ['function-item'];
+ e.classes = ['function-item'];
}
e.children[0].text = Utils.formatPercentNormalized(_getExclusiveT(item));
e.children[1].text = Utils.formatPercentNormalized(_getInclusiveT(item));
e.children[2] = new FunctionRefElement(_isolate, item.function,
- queue: _r.queue)..classes = const ['name'];
+ queue: _r.queue)..classes = ['name'];
}
Element _createFunctionHeader() =>
new DivElement()
- ..classes = const ['function-item']
+ ..classes = ['function-item']
..children = [
_createHeaderButton(const ['exclusive'], 'Execution(%)',
_Table.functions,
@@ -284,11 +284,11 @@ class CpuProfileTableElement extends HtmlElement implements Renderable {
Element _createCallee() {
final element = new DivElement()
- ..classes = const ['function-item']
+ ..classes = ['function-item']
..children = [
- new SpanElement()..classes = const ['inclusive']
+ new SpanElement()..classes = ['inclusive']
..text = '0%',
- new SpanElement()..classes = const ['name']
+ new SpanElement()..classes = ['name']
];
element.onClick.listen((e) {
if (e.target is AnchorElement) {
@@ -303,12 +303,12 @@ class CpuProfileTableElement extends HtmlElement implements Renderable {
void _updateCallee(Element e, item, int index) {
e.children[0].text = Utils.formatPercentNormalized(_getCalleeT(item));
e.children[1] = new FunctionRefElement(_isolate, item.function,
- queue: _r.queue)..classes = const ['name'];
+ queue: _r.queue)..classes = ['name'];
}
Element _createCalleeHeader() =>
new DivElement()
- ..classes = const ['function-item']
+ ..classes = ['function-item']
..children = [
_createHeaderButton(const ['inclusive'], 'Callees(%)',
_Table.callee,
@@ -322,11 +322,11 @@ class CpuProfileTableElement extends HtmlElement implements Renderable {
Element _createCaller() {
final element = new DivElement()
- ..classes = const ['function-item']
+ ..classes = ['function-item']
..children = [
- new SpanElement()..classes = const ['inclusive']
+ new SpanElement()..classes = ['inclusive']
..text = '0%',
- new SpanElement()..classes = const ['name']
+ new SpanElement()..classes = ['name']
];
element.onClick.listen((e) {
if (e.target is AnchorElement) {
@@ -341,12 +341,12 @@ class CpuProfileTableElement extends HtmlElement implements Renderable {
void _updateCaller(Element e, item, int index) {
e.children[0].text = Utils.formatPercentNormalized(_getCallerT(item));
e.children[1] = new FunctionRefElement(_isolate, item.function,
- queue: _r.queue)..classes = const ['name'];
+ queue: _r.queue)..classes = ['name'];
}
Element _createCallerHeader() =>
new DivElement()
- ..classes = const ['function-item']
+ ..classes = ['function-item']
..children = [
_createHeaderButton(const ['inclusive'], 'Callers(%)',
_Table.caller,
« no previous file with comments | « runtime/observatory/lib/src/elements/cpu_profile/virtual_tree.dart ('k') | runtime/observatory/lib/src/elements/eval_box.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698