Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(260)

Side by Side Diff: runtime/observatory/lib/src/elements/isolate/shared_summary.dart

Issue 2298563002: Removed const from classes arrays in Observatory (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2016, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2016, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 import 'dart:html'; 5 import 'dart:html';
6 import 'dart:async'; 6 import 'dart:async';
7 import 'package:observatory/models.dart' as M; 7 import 'package:observatory/models.dart' as M;
8 import 'package:observatory/utils.dart'; 8 import 'package:observatory/utils.dart';
9 import 'package:observatory/src/elements/helpers/rendering_scheduler.dart'; 9 import 'package:observatory/src/elements/helpers/rendering_scheduler.dart';
10 import 'package:observatory/src/elements/helpers/tag.dart'; 10 import 'package:observatory/src/elements/helpers/tag.dart';
(...skipping 39 matching lines...) Expand 10 before | Expand all | Expand 10 after
50 } 50 }
51 51
52 void render() { 52 void render() {
53 final newHeapUsed = Utils.formatSize(_isolate.newSpace.used); 53 final newHeapUsed = Utils.formatSize(_isolate.newSpace.used);
54 final newHeapCapacity = Utils.formatSize(_isolate.newSpace.capacity); 54 final newHeapCapacity = Utils.formatSize(_isolate.newSpace.capacity);
55 final oldHeapUsed = Utils.formatSize(_isolate.oldSpace.used); 55 final oldHeapUsed = Utils.formatSize(_isolate.oldSpace.used);
56 final oldHeapCapacity = Utils.formatSize(_isolate.oldSpace.capacity); 56 final oldHeapCapacity = Utils.formatSize(_isolate.oldSpace.capacity);
57 final content = [ 57 final content = [
58 new DivElement()..classes = ['menu'] 58 new DivElement()..classes = ['menu']
59 ..children = [ 59 ..children = [
60 new DivElement()..classes = const ['memberList'] 60 new DivElement()..classes = ['memberList']
61 ..children = [ 61 ..children = [
62 new DivElement()..classes = const ['memberItem'] 62 new DivElement()..classes = ['memberItem']
63 ..children = [ 63 ..children = [
64 new DivElement()..classes = const ['memberName'] 64 new DivElement()..classes = ['memberName']
65 ..text = 'new heap', 65 ..text = 'new heap',
66 new DivElement()..classes = const ['memberValue'] 66 new DivElement()..classes = ['memberValue']
67 ..text = '$newHeapUsed of $newHeapCapacity', 67 ..text = '$newHeapUsed of $newHeapCapacity',
68 ], 68 ],
69 new DivElement()..classes = const ['memberItem'] 69 new DivElement()..classes = ['memberItem']
70 ..children = [ 70 ..children = [
71 new DivElement()..classes = const ['memberName'] 71 new DivElement()..classes = ['memberName']
72 ..text = 'old heap', 72 ..text = 'old heap',
73 new DivElement()..classes = const ['memberValue'] 73 new DivElement()..classes = ['memberValue']
74 ..text = '$oldHeapUsed of $oldHeapCapacity', 74 ..text = '$oldHeapUsed of $oldHeapCapacity',
75 ] 75 ]
76 ], 76 ],
77 new BRElement(), 77 new BRElement(),
78 new DivElement() 78 new DivElement()
79 ..children = [ 79 ..children = [
80 new SpanElement()..text = 'see ', 80 new SpanElement()..text = 'see ',
81 new AnchorElement(href: Uris.debugger(_isolate)) 81 new AnchorElement(href: Uris.debugger(_isolate))
82 ..text = 'debug' 82 ..text = 'debug'
83 ], 83 ],
(...skipping 55 matching lines...) Expand 10 before | Expand all | Expand 10 after
139 ..children = [ 139 ..children = [
140 new SpanElement()..text = 'see ', 140 new SpanElement()..text = 'see ',
141 new AnchorElement(href: Uris.logging(_isolate)) 141 new AnchorElement(href: Uris.logging(_isolate))
142 ..text = 'logging' 142 ..text = 'logging'
143 ] 143 ]
144 ], 144 ],
145 new IsolateCounterChartElement(_isolate.counters, queue: _r.queue) 145 new IsolateCounterChartElement(_isolate.counters, queue: _r.queue)
146 ]; 146 ];
147 if (_isolate.error != null) { 147 if (_isolate.error != null) {
148 children = [ 148 children = [
149 new PreElement()..classes = const ['errorBox'] 149 new PreElement()..classes = ['errorBox']
150 ..text = _isolate.error.message, 150 ..text = _isolate.error.message,
151 new DivElement()..classes = const ['summary'] 151 new DivElement()..classes = ['summary']
152 ..children = content 152 ..children = content
153 ]; 153 ];
154 } else { 154 } else {
155 children = [ 155 children = [
156 new DivElement()..classes = const ['summary'] 156 new DivElement()..classes = ['summary']
157 ..children = content 157 ..children = content
158 ]; 158 ];
159 } 159 }
160 } 160 }
161 } 161 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698