Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(142)

Side by Side Diff: runtime/observatory/lib/src/elements/sentinel_view.dart

Issue 2298563002: Removed const from classes arrays in Observatory (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « runtime/observatory/lib/src/elements/script_view.dart ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 import 'dart:html'; 5 import 'dart:html';
6 import 'dart:async'; 6 import 'dart:async';
7 import 'package:observatory/models.dart' as M; 7 import 'package:observatory/models.dart' as M;
8 import 'package:observatory/src/elements/helpers/rendering_scheduler.dart'; 8 import 'package:observatory/src/elements/helpers/rendering_scheduler.dart';
9 import 'package:observatory/src/elements/helpers/tag.dart'; 9 import 'package:observatory/src/elements/helpers/tag.dart';
10 import 'package:observatory/src/elements/nav/bar.dart'; 10 import 'package:observatory/src/elements/nav/bar.dart';
(...skipping 67 matching lines...) Expand 10 before | Expand all | Expand 10 after
78 void render() { 78 void render() {
79 children = [ 79 children = [
80 new NavBarElement(queue: _r.queue) 80 new NavBarElement(queue: _r.queue)
81 ..children = [ 81 ..children = [
82 new NavTopMenuElement(queue: _r.queue), 82 new NavTopMenuElement(queue: _r.queue),
83 new NavVMMenuElement(_vm, _events, queue: _r.queue), 83 new NavVMMenuElement(_vm, _events, queue: _r.queue),
84 new NavIsolateMenuElement(_isolate, _events, queue: _r.queue), 84 new NavIsolateMenuElement(_isolate, _events, queue: _r.queue),
85 new NavMenuElement('sentinel', last: true, queue: _r.queue), 85 new NavMenuElement('sentinel', last: true, queue: _r.queue),
86 new NavNotifyElement(_notifications, queue: _r.queue) 86 new NavNotifyElement(_notifications, queue: _r.queue)
87 ], 87 ],
88 new DivElement()..classes = const ['content-centered-big'] 88 new DivElement()..classes = ['content-centered-big']
89 ..children = [ 89 ..children = [
90 new HeadingElement.h2() 90 new HeadingElement.h2()
91 ..text = 'Sentinel: #{_sentinel.valueAsString}', 91 ..text = 'Sentinel: #{_sentinel.valueAsString}',
92 new HRElement(), 92 new HRElement(),
93 new DivElement() 93 new DivElement()
94 ..text = _sentinelKindToDescription(_sentinel.kind), 94 ..text = _sentinelKindToDescription(_sentinel.kind),
95 new HRElement(), 95 new HRElement(),
96 new ViewFooterElement(queue: _r.queue) 96 new ViewFooterElement(queue: _r.queue)
97 ] 97 ]
98 ]; 98 ];
(...skipping 14 matching lines...) Expand all
113 case M.SentinelKind.optimizedOut: 113 case M.SentinelKind.optimizedOut:
114 return 'This object is no longer needed and has been removed by the ' 114 return 'This object is no longer needed and has been removed by the '
115 'optimizing compiler.'; 115 'optimizing compiler.';
116 case M.SentinelKind.free: 116 case M.SentinelKind.free:
117 return ''; 117 return '';
118 } 118 }
119 throw new Exception('Unknown SentinelKind: $kind'); 119 throw new Exception('Unknown SentinelKind: $kind');
120 } 120 }
121 121
122 } 122 }
OLDNEW
« no previous file with comments | « runtime/observatory/lib/src/elements/script_view.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698