Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(912)

Unified Diff: runtime/observatory/lib/src/elements/object_common.dart

Issue 2298563002: Removed const from classes arrays in Observatory (Closed)
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/observatory/lib/src/elements/object_common.dart
diff --git a/runtime/observatory/lib/src/elements/object_common.dart b/runtime/observatory/lib/src/elements/object_common.dart
index f82c7ec2c2198fdf9b54d4dd1e40797f15f3f9b3..3e40ca2b04716b04241f17e429e165f7d1f1bf04 100644
--- a/runtime/observatory/lib/src/elements/object_common.dart
+++ b/runtime/observatory/lib/src/elements/object_common.dart
@@ -94,13 +94,13 @@ class ObjectCommonElement extends HtmlElement implements Renderable {
_instances,
queue: _r.queue);
children = [
- new DivElement()..classes = const ['memberList']
+ new DivElement()..classes = ['memberList']
..children = [
- new DivElement()..classes = const ['memberItem']
+ new DivElement()..classes = ['memberItem']
..children = [
- new DivElement()..classes = const ['memberName']
+ new DivElement()..classes = ['memberName']
..text = 'Class ',
- new DivElement()..classes = const ['memberValue']
+ new DivElement()..classes = ['memberValue']
..children = [
_object.clazz == null
? (new SpanElement()..text = '...')
@@ -108,45 +108,45 @@ class ObjectCommonElement extends HtmlElement implements Renderable {
queue: _r.queue)
]
],
- new DivElement()..classes = const ['memberItem']
+ new DivElement()..classes = ['memberItem']
..title = 'Space for this object in memory'
..children = [
- new DivElement()..classes = const ['memberName']
+ new DivElement()..classes = ['memberName']
..text = 'Shallow size ',
- new DivElement()..classes = const ['memberValue']
+ new DivElement()..classes = ['memberValue']
..text = Utils.formatSize(_object.size ?? 0)
],
- new DivElement()..classes = const ['memberItem']
+ new DivElement()..classes = ['memberItem']
..title = 'Space reachable from this object, '
'excluding class references'
..children = [
- new DivElement()..classes = const ['memberName']
+ new DivElement()..classes = ['memberName']
..text = 'Reachable size ',
- new DivElement()..classes = const ['memberValue']
+ new DivElement()..classes = ['memberValue']
..children = _createReachableSizeValue()
],
- new DivElement()..classes = const ['memberItem']
+ new DivElement()..classes = ['memberItem']
..title = 'Space that would be reclaimed if references to this '
'object were replaced with null'
..children = [
- new DivElement()..classes = const ['memberName']
+ new DivElement()..classes = ['memberName']
..text = 'Retained size ',
- new DivElement()..classes = const ['memberValue']
+ new DivElement()..classes = ['memberValue']
..children = _createRetainedSizeValue()
],
- new DivElement()..classes = const ['memberItem']
+ new DivElement()..classes = ['memberItem']
..children = [
- new DivElement()..classes = const ['memberName']
+ new DivElement()..classes = ['memberName']
..text = 'Retaining path ',
- new DivElement()..classes = const ['memberValue']
+ new DivElement()..classes = ['memberValue']
..children = [_path]
],
- new DivElement()..classes = const ['memberItem']
+ new DivElement()..classes = ['memberItem']
..title = 'Objects which directly reference this object'
..children = [
- new DivElement()..classes = const ['memberName']
+ new DivElement()..classes = ['memberName']
..text = 'Inbound references ',
- new DivElement()..classes = const ['memberValue']
+ new DivElement()..classes = ['memberValue']
..children = [_inbounds]
]
]
« no previous file with comments | « runtime/observatory/lib/src/elements/megamorphiccache_view.dart ('k') | runtime/observatory/lib/src/elements/object_view.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698