Make CaretBase a DisplayItemClient.

Make CaretBase a DisplayItemClient.

From chrishtr@'s http://crrev.com/2296203002 with test added. Fixes caret
invalidation in textarea where caret is scrolled outside of visible textarea
rect.

BUG=634094
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Committed: https://crrev.com/5153d9b53989b32068b7759aa0253a1e5662492a
Cr-Commit-Position: refs/heads/master@{#416191}

[wkorman, 2016-08-31 21:08:29]

Description was changed from

==========
Make CaretBase a DisplayItemClient.

From chrishtr@'s http://crrev.com/2296203002 with test added. Fixes caret
invalidation in textarea where caret is scrolled outside of visible textarea
rect.

BUG=634094
==========

to

==========
Make CaretBase a DisplayItemClient.

From chrishtr@'s http://crrev.com/2296203002 with test added. Fixes caret
invalidation in textarea where caret is scrolled outside of visible textarea
rect.

BUG=634094
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[wkorman, 2016-08-31 21:10:39]

wkorman@chromium.org changed reviewers:
+ chrishtr@chromium.org

[wkorman, 2016-08-31 21:10:40]

If you're feeling lazy, this integrated your patch with the test. Using this as
an excuse to test the new rebaseline flow.

[chrishtr, 2016-09-01 15:00:13]

https://codereview.chromium.org/2293293003/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/paint/BlockPainter.cpp (right):

https://codereview.chromium.org/2293293003/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/paint/BlockPainter.cpp:197: // LOG(ERROR) <<
"Painting caret [bounds=" << bounds.toString() << ", obj=" <<
m_layoutBlock.debugName() << "].";
remove these comments

https://codereview.chromium.org/2293293003/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/paint/BlockPainter.cpp:199: // TODO(wkorman):
Consider moving recorder into caret, having caret be DisplayItemClient for
itself,
The recorder is already in CaretBase.

[wkorman, 2016-09-01 23:40:41]

https://codereview.chromium.org/2293293003/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/paint/BlockPainter.cpp (right):

https://codereview.chromium.org/2293293003/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/paint/BlockPainter.cpp:197: // LOG(ERROR) <<
"Painting caret [bounds=" << bounds.toString() << ", obj=" <<
m_layoutBlock.debugName() << "].";
On 2016/09/01 15:00:13, chrishtr wrote:
> remove these comments

Done.

https://codereview.chromium.org/2293293003/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/paint/BlockPainter.cpp:199: // TODO(wkorman):
Consider moving recorder into caret, having caret be DisplayItemClient for
itself,
On 2016/09/01 15:00:13, chrishtr wrote:
> The recorder is already in CaretBase.

Done.

[wkorman, 2016-09-01 23:40:49]

The CQ bit was checked by wkorman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-01 23:41:16]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[wkorman, 2016-09-01 23:43:49]

For the record, most recent patchset includes changes to FrameCaret and
LayoutBlock to fix:

paint/invalidation/caret-color.html

which had out-of-sync caret color vs text color when style changed, and:

fast/forms/relayout-shifts-inner-editor.html

which was missing the caret in pixel results due to under-invalidation.

[commit-bot: I haz the power, 2016-09-01 23:44:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-01 23:44:10]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[chrishtr, 2016-09-01 23:45:58]

lgtm

LGTM with nit fixed.

https://codereview.chromium.org/2293293003/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/editing/FrameCaret.h (right):

https://codereview.chromium.org/2293293003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/editing/FrameCaret.h:55: void
invalidateCaretRect(bool forceInvalidation);
Document briefly.

[wkorman, 2016-09-02 00:02:46]

https://codereview.chromium.org/2293293003/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/editing/FrameCaret.h (right):

https://codereview.chromium.org/2293293003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/editing/FrameCaret.h:55: void
invalidateCaretRect(bool forceInvalidation);
On 2016/09/01 23:45:58, chrishtr wrote:
> Document briefly.

Done.

[wkorman, 2016-09-02 00:03:03]

The CQ bit was checked by wkorman@chromium.org

[wkorman, 2016-09-02 00:03:03]

The patchset sent to the CQ was uploaded after l-g-t-m from
chrishtr@chromium.org
Link to the patchset: https://codereview.chromium.org/2293293003/#ps40001
(title: "Update docs and sync to head.")

[commit-bot: I haz the power, 2016-09-02 00:03:25]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-02 00:57:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-02 00:57:24]

Try jobs failed on following builders:
  linux_layout_tests_slimming_paint_v2 on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_layout_te...)

[wkorman, 2016-09-02 03:41:19]

The CQ bit was checked by wkorman@chromium.org

[wkorman, 2016-09-02 03:41:19]

The patchset sent to the CQ was uploaded after l-g-t-m from
chrishtr@chromium.org
Link to the patchset: https://codereview.chromium.org/2293293003/#ps60001
(title: "Fix unit test and disable failing test on SPv2.")

[commit-bot: I haz the power, 2016-09-02 03:41:46]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-02 05:19:15]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-09-02 05:20:38]

Description was changed from

==========
Make CaretBase a DisplayItemClient.

From chrishtr@'s http://crrev.com/2296203002 with test added. Fixes caret
invalidation in textarea where caret is scrolled outside of visible textarea
rect.

BUG=634094
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Make CaretBase a DisplayItemClient.

From chrishtr@'s http://crrev.com/2296203002 with test added. Fixes caret
invalidation in textarea where caret is scrolled outside of visible textarea
rect.

BUG=634094
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Committed: https://crrev.com/5153d9b53989b32068b7759aa0253a1e5662492a
Cr-Commit-Position: refs/heads/master@{#416191}
==========

[commit-bot: I haz the power, 2016-09-02 05:20:39]

Patchset 4 (id:??) landed as
https://crrev.com/5153d9b53989b32068b7759aa0253a1e5662492a
Cr-Commit-Position: refs/heads/master@{#416191}