Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Side by Side Diff: third_party/WebKit/Source/core/editing/FrameCaret.h

Issue 2293293003: Make CaretBase a DisplayItemClient. (Closed)
Patch Set: Fix caret invalidation when style changes. Update test expectations. Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2004, 2008, 2009, 2010 Apple Inc. All rights reserved. 2 * Copyright (C) 2004, 2008, 2009, 2010 Apple Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
(...skipping 34 matching lines...) Expand 10 before | Expand all | Expand 10 after
45 45
46 // Used to suspend caret blinking while the mouse is down. 46 // Used to suspend caret blinking while the mouse is down.
47 void setCaretBlinkingSuspended(bool suspended) { m_isCaretBlinkingSuspended = suspended; } 47 void setCaretBlinkingSuspended(bool suspended) { m_isCaretBlinkingSuspended = suspended; }
48 bool isCaretBlinkingSuspended() const { return m_isCaretBlinkingSuspended; } 48 bool isCaretBlinkingSuspended() const { return m_isCaretBlinkingSuspended; }
49 void stopCaretBlinkTimer(); 49 void stopCaretBlinkTimer();
50 void startBlinkCaret(); 50 void startBlinkCaret();
51 51
52 void setCaretVisibility(CaretVisibility) override; 52 void setCaretVisibility(CaretVisibility) override;
53 bool isCaretBoundsDirty() const { return m_caretRectDirty; } 53 bool isCaretBoundsDirty() const { return m_caretRectDirty; }
54 void setCaretRectNeedsUpdate(); 54 void setCaretRectNeedsUpdate();
55 void invalidateCaretRect(); 55 void invalidateCaretRect(bool forceInvalidation);
chrishtr 2016/09/01 23:45:58 Document briefly.
wkorman 2016/09/02 00:02:46 Done.
56 IntRect absoluteCaretBounds(); 56 IntRect absoluteCaretBounds();
57 57
58 bool shouldShowBlockCursor() const { return m_shouldShowBlockCursor; } 58 bool shouldShowBlockCursor() const { return m_shouldShowBlockCursor; }
59 void setShouldShowBlockCursor(bool); 59 void setShouldShowBlockCursor(bool);
60 60
61 void paintCaret(GraphicsContext&, const LayoutPoint&); 61 void paintCaret(GraphicsContext&, const LayoutPoint&);
62 62
63 void dataWillChange(const CharacterData&); 63 void dataWillChange(const CharacterData&);
64 void nodeWillBeRemoved(Node&); 64 void nodeWillBeRemoved(Node&);
65 65
(...skipping 24 matching lines...) Expand all
90 Timer<FrameCaret> m_caretBlinkTimer; 90 Timer<FrameCaret> m_caretBlinkTimer;
91 bool m_caretRectDirty : 1; 91 bool m_caretRectDirty : 1;
92 bool m_shouldPaintCaret : 1; 92 bool m_shouldPaintCaret : 1;
93 bool m_isCaretBlinkingSuspended : 1; 93 bool m_isCaretBlinkingSuspended : 1;
94 bool m_shouldShowBlockCursor : 1; 94 bool m_shouldShowBlockCursor : 1;
95 }; 95 };
96 96
97 } // namespace blink 97 } // namespace blink
98 98
99 #endif // FrameCaret_h 99 #endif // FrameCaret_h
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/core/editing/CaretBase.cpp ('k') | third_party/WebKit/Source/core/editing/FrameCaret.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698