third_party/WebKit/Source/core/layout/LayoutBlock.h - Issue 2293293003: Make CaretBase a DisplayItemClient.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/LayoutBlock.h

Issue 2293293003: Make CaretBase a DisplayItemClient. (Closed)

Patch Set: Fix unit test and disable failing test on SPv2. Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/layout/LayoutBlock.h

diff --git a/third_party/WebKit/Source/core/layout/LayoutBlock.h b/third_party/WebKit/Source/core/layout/LayoutBlock.h

index 97075b36f471ea1378c5215d37fd8755b1c3dcc4..b0d81637cb291e4ec5785cde3957ecbb8f67d451 100644

--- a/third_party/WebKit/Source/core/layout/LayoutBlock.h

+++ b/third_party/WebKit/Source/core/layout/LayoutBlock.h

@@ -361,6 +361,10 @@ public:

bool hasCursorCaret() const;

bool hasDragCaret() const;

bool hasCaret() const { return hasCursorCaret() || hasDragCaret(); }

+ void invalidateCaret() const;

+protected:

+ PaintInvalidationReason invalidatePaintIfNeeded(const PaintInvalidationState&) override;

private:

LayoutRect localCaretRect(InlineBox*, int caretOffset, LayoutUnit* extraWidthToEndOfLine = nullptr) final;