Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Side by Side Diff: third_party/WebKit/Source/core/layout/LayoutObject.h

Issue 2293293003: Make CaretBase a DisplayItemClient. (Closed)
Patch Set: Fix unit test and disable failing test on SPv2. Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2000 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 2000 Lars Knoll (knoll@kde.org)
3 * (C) 2000 Antti Koivisto (koivisto@kde.org) 3 * (C) 2000 Antti Koivisto (koivisto@kde.org)
4 * (C) 2000 Dirk Mueller (mueller@kde.org) 4 * (C) 2000 Dirk Mueller (mueller@kde.org)
5 * (C) 2004 Allan Sandfeld Jensen (kde@carewolf.com) 5 * (C) 2004 Allan Sandfeld Jensen (kde@carewolf.com)
6 * Copyright (C) 2003, 2004, 2005, 2006, 2007, 2008, 2009, 2012 Apple Inc. All r ights reserved. 6 * Copyright (C) 2003, 2004, 2005, 2006, 2007, 2008, 2009, 2012 Apple Inc. All r ights reserved.
7 * Copyright (C) 2009 Google Inc. All rights reserved. 7 * Copyright (C) 2009 Google Inc. All rights reserved.
8 * 8 *
9 * This library is free software; you can redistribute it and/or 9 * This library is free software; you can redistribute it and/or
10 * modify it under the terms of the GNU Library General Public 10 * modify it under the terms of the GNU Library General Public
(...skipping 1090 matching lines...) Expand 10 before | Expand all | Expand 10 after
1101 // different document. 1101 // different document.
1102 // 1102 //
1103 // This is the container that should be passed to 1103 // This is the container that should be passed to
1104 // the '*forPaintInvalidation' methods. 1104 // the '*forPaintInvalidation' methods.
1105 const LayoutBoxModelObject& containerForPaintInvalidation() const; 1105 const LayoutBoxModelObject& containerForPaintInvalidation() const;
1106 1106
1107 bool isPaintInvalidationContainer() const; 1107 bool isPaintInvalidationContainer() const;
1108 1108
1109 // Invalidate the paint of a specific subrectangle within a given object. Th e rect is in the object's coordinate space. 1109 // Invalidate the paint of a specific subrectangle within a given object. Th e rect is in the object's coordinate space.
1110 // If a DisplayItemClient is specified, that client is invalidated rather th an |this|. 1110 // If a DisplayItemClient is specified, that client is invalidated rather th an |this|.
1111 void invalidatePaintRectangle(const LayoutRect&, DisplayItemClient* = nullpt r) const; 1111 // Returns the visual rect that was invalidated (i.e, invalidation in the sp ace of the GraphicsLayer backing this LayoutObject).
1112 LayoutRect invalidatePaintRectangle(const LayoutRect&, DisplayItemClient* = nullptr) const;
1112 1113
1113 // Walk the tree after layout issuing paint invalidations for layoutObjects that have changed or moved, updating bounds that have changed, and clearing pain t invalidation state. 1114 // Walk the tree after layout issuing paint invalidations for layoutObjects that have changed or moved, updating bounds that have changed, and clearing pain t invalidation state.
1114 virtual void invalidateTreeIfNeeded(const PaintInvalidationState&); 1115 virtual void invalidateTreeIfNeeded(const PaintInvalidationState&);
1115 1116
1116 void setShouldDoFullPaintInvalidationIncludingNonCompositingDescendants(); 1117 void setShouldDoFullPaintInvalidationIncludingNonCompositingDescendants();
1117 1118
1118 // Returns true if the object itself will not generate any effective painted output no matter what 1119 // Returns true if the object itself will not generate any effective painted output no matter what
1119 // size the object is. For example, this function can return false for an ob ject whose size is 1120 // size the object is. For example, this function can return false for an ob ject whose size is
1120 // currently 0x0 but would have effective painted output if it was set a non -empty size. 1121 // currently 0x0 but would have effective painted output if it was set a non -empty size.
1121 // It's used to skip unforced paint invalidation (which is when shouldDoFull PaintInvalidation 1122 // It's used to skip unforced paint invalidation (which is when shouldDoFull PaintInvalidation
(...skipping 1011 matching lines...) Expand 10 before | Expand all | Expand 10 after
2133 void showTree(const blink::LayoutObject*); 2134 void showTree(const blink::LayoutObject*);
2134 void showLineTree(const blink::LayoutObject*); 2135 void showLineTree(const blink::LayoutObject*);
2135 void showLayoutTree(const blink::LayoutObject* object1); 2136 void showLayoutTree(const blink::LayoutObject* object1);
2136 // We don't make object2 an optional parameter so that showLayoutTree 2137 // We don't make object2 an optional parameter so that showLayoutTree
2137 // can be called from gdb easily. 2138 // can be called from gdb easily.
2138 void showLayoutTree(const blink::LayoutObject* object1, const blink::LayoutObjec t* object2); 2139 void showLayoutTree(const blink::LayoutObject* object1, const blink::LayoutObjec t* object2);
2139 2140
2140 #endif 2141 #endif
2141 2142
2142 #endif // LayoutObject_h 2143 #endif // LayoutObject_h
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/core/layout/LayoutBlock.cpp ('k') | third_party/WebKit/Source/core/layout/LayoutObject.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698