third_party/WebKit/Source/core/editing/FrameSelection.cpp - Issue 2293293003: Make CaretBase a DisplayItemClient.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/FrameSelection.cpp

Issue 2293293003: Make CaretBase a DisplayItemClient. (Closed)

Patch Set: Fix unit test and disable failing test on SPv2. Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/editing/FrameSelection.cpp

diff --git a/third_party/WebKit/Source/core/editing/FrameSelection.cpp b/third_party/WebKit/Source/core/editing/FrameSelection.cpp

index 74496ba8aa75966a2bc24c1cc4a04e1198fbe180..85b7535565c7387fa580b8f0223add69d5125224 100644

--- a/third_party/WebKit/Source/core/editing/FrameSelection.cpp

+++ b/third_party/WebKit/Source/core/editing/FrameSelection.cpp

@@ -708,9 +708,9 @@ IntRect FrameSelection::absoluteCaretBounds()

return m_frameCaret->absoluteCaretBounds();

}

-void FrameSelection::invalidateCaretRect()

+void FrameSelection::invalidateCaretRect(bool forceInvalidation)

{

- m_frameCaret->invalidateCaretRect();

+ m_frameCaret->invalidateCaretRect(forceInvalidation);

}

void FrameSelection::dataWillChange(const CharacterData& node)