Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(386)

Side by Side Diff: third_party/WebKit/Source/core/editing/FrameSelection.cpp

Issue 2293293003: Make CaretBase a DisplayItemClient. (Closed)
Patch Set: Fix unit test and disable failing test on SPv2. Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2004, 2008, 2009, 2010 Apple Inc. All rights reserved. 2 * Copyright (C) 2004, 2008, 2009, 2010 Apple Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
(...skipping 690 matching lines...) Expand 10 before | Expand all | Expand 10 after
701 return nullptr; 701 return nullptr;
702 return CaretBase::caretLayoutObject(selection().start().anchorNode()); 702 return CaretBase::caretLayoutObject(selection().start().anchorNode());
703 } 703 }
704 704
705 IntRect FrameSelection::absoluteCaretBounds() 705 IntRect FrameSelection::absoluteCaretBounds()
706 { 706 {
707 DCHECK(selection().isValidFor(*m_frame->document())); 707 DCHECK(selection().isValidFor(*m_frame->document()));
708 return m_frameCaret->absoluteCaretBounds(); 708 return m_frameCaret->absoluteCaretBounds();
709 } 709 }
710 710
711 void FrameSelection::invalidateCaretRect() 711 void FrameSelection::invalidateCaretRect(bool forceInvalidation)
712 { 712 {
713 m_frameCaret->invalidateCaretRect(); 713 m_frameCaret->invalidateCaretRect(forceInvalidation);
714 } 714 }
715 715
716 void FrameSelection::dataWillChange(const CharacterData& node) 716 void FrameSelection::dataWillChange(const CharacterData& node)
717 { 717 {
718 m_frameCaret->dataWillChange(node); 718 m_frameCaret->dataWillChange(node);
719 } 719 }
720 720
721 void FrameSelection::paintCaret(GraphicsContext& context, const LayoutPoint& pai ntOffset) 721 void FrameSelection::paintCaret(GraphicsContext& context, const LayoutPoint& pai ntOffset)
722 { 722 {
723 m_frameCaret->paintCaret(context, paintOffset); 723 m_frameCaret->paintCaret(context, paintOffset);
(...skipping 648 matching lines...) Expand 10 before | Expand all | Expand 10 after
1372 1372
1373 void showTree(const blink::FrameSelection* sel) 1373 void showTree(const blink::FrameSelection* sel)
1374 { 1374 {
1375 if (sel) 1375 if (sel)
1376 sel->showTreeForThis(); 1376 sel->showTreeForThis();
1377 else 1377 else
1378 LOG(INFO) << "Cannot showTree for <null> FrameSelection."; 1378 LOG(INFO) << "Cannot showTree for <null> FrameSelection.";
1379 } 1379 }
1380 1380
1381 #endif 1381 #endif
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/core/editing/FrameSelection.h ('k') | third_party/WebKit/Source/core/layout/LayoutBlock.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698