third_party/WebKit/Source/core/layout/LayoutObject.cpp - Issue 2293293003: Make CaretBase a DisplayItemClient.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/LayoutObject.cpp

Issue 2293293003: Make CaretBase a DisplayItemClient. (Closed)

Patch Set: Fix unit test and disable failing test on SPv2. Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/layout/LayoutObject.cpp

diff --git a/third_party/WebKit/Source/core/layout/LayoutObject.cpp b/third_party/WebKit/Source/core/layout/LayoutObject.cpp

index 52a94d8a16c610ed8ba5f53069053a1001615ead..2d88f2f710a33a441126e99ab60a724e53fb337d 100644

--- a/third_party/WebKit/Source/core/layout/LayoutObject.cpp

+++ b/third_party/WebKit/Source/core/layout/LayoutObject.cpp

@@ -1119,9 +1119,9 @@ IntSize LayoutObject::scrollAdjustmentForPaintInvalidation(const LayoutBoxModelO

return IntSize();

}

-void LayoutObject::invalidatePaintRectangle(const LayoutRect& dirtyRect, DisplayItemClient* displayItemClient) const

+LayoutRect LayoutObject::invalidatePaintRectangle(const LayoutRect& dirtyRect, DisplayItemClient* displayItemClient) const

{

- ObjectPaintInvalidator(*this).invalidatePaintRectangle(dirtyRect, displayItemClient);

+ return ObjectPaintInvalidator(*this).invalidatePaintRectangle(dirtyRect, displayItemClient);

}

void LayoutObject::invalidateTreeIfNeeded(const PaintInvalidationState& paintInvalidationState)