Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(258)

Issue 2282213002: [LayoutNG] Introduce NGPhysicalFragment and make NGFragment a 'view' (Closed)

Created:
4 years, 3 months ago by ikilpatrick
Modified:
4 years, 3 months ago
CC:
chromium-reviews, ojan+watch_chromium.org, szager+layoutwatch_chromium.org, zoltan1, blink-reviews-layout_chromium.org, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, blink-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[LayoutNG] Introduce NGPhysicalFragment and make NGFragment a 'view' - Adds a bunch of conversion functions between physical and logical offsets and sizes. - The NGAlgorithm now outputs a NGPhysicalFragment (NGFragment output doesn't make sense in this instance as would immediately get unwrapped and destroyed). BUG=635619 Committed: https://crrev.com/e9e67c7f04956745211b80a1f2996209f9aa1b7c Cr-Commit-Position: refs/heads/master@{#415543}

Patch Set 1 #

Patch Set 2 : .. #

Patch Set 3 : [LayoutNG] Introduce NGPhysicalFragment and make NGFragment a 'view' #

Patch Set 4 : ... #

Total comments: 11

Patch Set 5 : address comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+560 lines, -150 lines) Patch
M third_party/WebKit/Source/core/BUILD.gn View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/core.gypi View 1 2 3 4 2 chunks +7 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm.h View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm.cc View 1 2 3 4 4 chunks +8 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm_test.cc View 1 2 2 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_box.h View 1 2 2 chunks +9 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_box.cc View 1 2 3 5 chunks +23 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_constraint_space.h View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_constraint_space.cc View 1 2 3 4 4 chunks +4 lines, -19 lines 0 comments Download
A third_party/WebKit/Source/core/layout/ng/ng_direction.h View 1 2 1 chunk +19 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/core/layout/ng/ng_direction.cc View 1 2 1 chunk +24 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_fragment.h View 1 2 3 2 chunks +4 lines, -16 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_fragment_base.h View 1 2 3 1 chunk +18 lines, -22 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_fragment_base.cc View 1 2 3 1 chunk +34 lines, -25 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_fragment_builder.h View 1 2 2 chunks +7 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_fragment_builder.cc View 1 2 3 4 2 chunks +23 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_layout_algorithm.h View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_physical_constraint_space.h View 1 2 3 4 1 chunk +0 lines, -2 lines 0 comments Download
A third_party/WebKit/Source/core/layout/ng/ng_physical_fragment.h View 1 2 1 chunk +41 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/core/layout/ng/ng_physical_fragment_base.h View 1 2 1 chunk +83 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/core/layout/ng/ng_physical_fragment_base.cc View 1 chunk +19 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/core/layout/ng/ng_physical_text_fragment.h View 1 chunk +43 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_text_fragment.h View 1 2 2 chunks +7 lines, -15 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_text_fragment.cc View 1 chunk +1 line, -7 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_units.h View 1 2 3 chunks +38 lines, -1 line 0 comments Download
A third_party/WebKit/Source/core/layout/ng/ng_units.cc View 1 2 1 chunk +64 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/core/layout/ng/ng_units_test.cc View 1 2 1 chunk +74 lines, -0 lines 0 comments Download

Messages

Total messages: 23 (12 generated)
ikilpatrick
Not entirely happy about how this updates the positions now...
4 years, 3 months ago (2016-08-29 23:31:40 UTC) #3
eae
I think this is a step in the right direction. Let's give it a try ...
4 years, 3 months ago (2016-08-29 23:40:25 UTC) #4
cbiesinger
lgtm but note comments below, especially about content_size_ https://codereview.chromium.org/2282213002/diff/60001/third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm.cc File third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm.cc (right): https://codereview.chromium.org/2282213002/diff/60001/third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm.cc#newcode58 third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm.cc:58: content_size_ ...
4 years, 3 months ago (2016-08-30 15:03:50 UTC) #5
cbiesinger
Also, fyi, this needs to be rebased (git cl patch got me an error)
4 years, 3 months ago (2016-08-30 19:14:06 UTC) #6
ikilpatrick
https://codereview.chromium.org/2282213002/diff/60001/third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm.cc File third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm.cc (right): https://codereview.chromium.org/2282213002/diff/60001/third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm.cc#newcode58 third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm.cc:58: content_size_ + child_margins.block_start)); On 2016/08/30 15:03:49, cbiesinger wrote: > ...
4 years, 3 months ago (2016-08-30 22:29:53 UTC) #9
cbiesinger1
Lgtm https://codereview.chromium.org/2282213002/diff/60001/third_party/WebKit/Source/core/layout/ng/ng_fragment_builder.cc File third_party/WebKit/Source/core/layout/ng/ng_fragment_builder.cc (right): https://codereview.chromium.org/2282213002/diff/60001/third_party/WebKit/Source/core/layout/ng/ng_fragment_builder.cc#newcode65 third_party/WebKit/Source/core/layout/ng/ng_fragment_builder.cc:65: writing_mode_, direction_, physical_size, child->Size())); On 2016/08/30 22:29:53, ikilpatrick ...
4 years, 3 months ago (2016-08-30 23:05:32 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2282213002/80001
4 years, 3 months ago (2016-08-30 23:38:18 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/284507)
4 years, 3 months ago (2016-08-31 00:16:45 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2282213002/80001
4 years, 3 months ago (2016-08-31 01:05:14 UTC) #19
commit-bot: I haz the power
Committed patchset #5 (id:80001)
4 years, 3 months ago (2016-08-31 02:40:46 UTC) #21
commit-bot: I haz the power
4 years, 3 months ago (2016-08-31 02:42:59 UTC) #23
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/e9e67c7f04956745211b80a1f2996209f9aa1b7c
Cr-Commit-Position: refs/heads/master@{#415543}

Powered by Google App Engine
This is Rietveld 408576698