third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm_test.cc - Issue 2282213002: [LayoutNG] Introduce NGPhysicalFragment and make NGFragment a 'view'

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm_test.cc

Issue 2282213002: [LayoutNG] Introduce NGPhysicalFragment and make NGFragment a 'view' (Closed)

Patch Set: address comments. Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm.cc ('k') | third_party/WebKit/Source/core/layout/ng/ng_box.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm_test.cc

diff --git a/third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm_test.cc b/third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm_test.cc

index 87bc026b80b4ccb30ba758e576b2b983d8e90eb7..f239f14719b25fa815b681e07e8f88faa541f101 100644

--- a/third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm_test.cc

+++ b/third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm_test.cc

@@ -5,7 +5,7 @@

#include "core/layout/ng/ng_block_layout_algorithm.h"

#include "core/layout/ng/ng_constraint_space.h"

-#include "core/layout/ng/ng_fragment.h"

+#include "core/layout/ng/ng_physical_fragment.h"

#include "core/layout/ng/ng_length_utils.h"

#include "core/style/ComputedStyle.h"

#include "testing/gtest/include/gtest/gtest.h"

@@ -28,11 +28,11 @@ TEST_F(NGBlockLayoutAlgorithmTest, FixedSize) {

HorizontalTopBottom, NGLogicalSize(LayoutUnit(100), NGSizeIndefinite));

NGBlockLayoutAlgorithm algorithm(style_, nullptr);

- NGFragment* frag;

+ NGPhysicalFragment* frag;

while (!algorithm.Layout(space, &frag))

;

- EXPECT_EQ(frag->InlineSize(), LayoutUnit(30));

- EXPECT_EQ(frag->BlockSize(), LayoutUnit(40));

+ EXPECT_EQ(frag->Width(), LayoutUnit(30));

+ EXPECT_EQ(frag->Height(), LayoutUnit(40));

}

} // namespace