Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(513)

Unified Diff: third_party/WebKit/Source/core/layout/ng/ng_fragment.h

Issue 2282213002: [LayoutNG] Introduce NGPhysicalFragment and make NGFragment a 'view' (Closed)
Patch Set: address comments. Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/layout/ng/ng_fragment.h
diff --git a/third_party/WebKit/Source/core/layout/ng/ng_fragment.h b/third_party/WebKit/Source/core/layout/ng/ng_fragment.h
index ff0030a5cc62b0121672f114bc6e14a27ab13f47..404b3b859f56280b50848cd75b385403872d5c63 100644
--- a/third_party/WebKit/Source/core/layout/ng/ng_fragment.h
+++ b/third_party/WebKit/Source/core/layout/ng/ng_fragment.h
@@ -8,6 +8,7 @@
#include "core/CoreExport.h"
#include "core/layout/ng/ng_fragment_base.h"
#include "core/layout/ng/ng_constraint_space.h"
+#include "core/layout/ng/ng_physical_fragment.h"
#include "core/layout/ng/ng_units.h"
#include "core/layout/ng/ng_writing_mode.h"
#include "platform/LayoutUnit.h"
@@ -18,23 +19,10 @@ namespace blink {
class CORE_EXPORT NGFragment final : public NGFragmentBase {
public:
- // This modified the passed-in children vector.
- NGFragment(NGLogicalSize size,
- NGLogicalSize overflow,
- NGWritingMode writingMode,
+ NGFragment(NGWritingMode writing_mode,
NGDirection direction,
- HeapVector<Member<const NGFragmentBase>>& children)
- : NGFragmentBase(size, overflow, writingMode, direction, FragmentBox) {
- children_.swap(children);
- }
-
- DEFINE_INLINE_TRACE_AFTER_DISPATCH() {
- visitor->trace(children_);
- NGFragmentBase::traceAfterDispatch(visitor);
- }
-
- private:
- HeapVector<Member<const NGFragmentBase>> children_;
+ NGPhysicalFragment* physical_fragment)
+ : NGFragmentBase(writing_mode, direction, physical_fragment) {}
};
} // namespace blink
« no previous file with comments | « third_party/WebKit/Source/core/layout/ng/ng_direction.cc ('k') | third_party/WebKit/Source/core/layout/ng/ng_fragment_base.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698